Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing fetcher tests #10613

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix failing fetcher tests #10613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf144dd
Fix AstrophysicsDataSystemTest
k3KAW8Pnf7mkmdSMPHz27 Nov 1, 2023
3609018
Disable CCSB tests
k3KAW8Pnf7mkmdSMPHz27 Nov 1, 2023
25f8039
Fix path to LICENSE
k3KAW8Pnf7mkmdSMPHz27 Nov 1, 2023
b1cbc98
Fix suffix of LICENSE
k3KAW8Pnf7mkmdSMPHz27 Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public void setUp() throws Exception {
.withField(StandardField.TITLE, "Multiyear On-Orbit Calibration and Performance of Terra MODIS Reflective Solar Bands")
.withField(StandardField.VOLUME, "45")
.withField(StandardField.YEAR, "2007")
.withField(StandardField.KEYWORDS, "Earth Science")
.withField(StandardField.URL, "https://ui.adsabs.harvard.edu/abs/2007ITGRS..45..879X");

ingersollPollardEntry = new BibEntry(StandardEntryType.Article)
Expand All @@ -125,7 +126,7 @@ public void setUp() throws Exception {
.withField(StandardField.AUTHOR, "Lucey, Paul G. and Blewett, David T. and Jolliff, Bradley L.")
.withField(StandardField.DOI, "10.1029/1999JE001117")
.withField(StandardField.JOURNAL, "\\jgr")
.withField(StandardField.KEYWORDS, "Planetology: Solid Surface Planets: Composition, Planetology: Solid Surface Planets: Remote sensing, Planetology: Solid Surface Planets: Surface materials and properties, Planetology: Solar System Objects: Moon (1221)")
.withField(StandardField.KEYWORDS, "Planetology: Solid Surface Planets: Composition, Planetology: Solid Surface Planets: Remote sensing, Planetology: Solid Surface Planets: Surface materials and properties, Planetology: Solar System Objects: Moon (1221), Earth Science")
.withField(StandardField.PAGES, "20297-20306")
.withField(StandardField.TITLE, "Lunar iron and titanium abundance algorithms based on final processing of Clementine ultraviolet-visible images")
.withField(StandardField.VOLUME, "105")
Expand Down
2 changes: 2 additions & 0 deletions ...g/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@
import org.apache.lucene.queryparser.flexible.core.QueryNodeParseException;
import org.apache.lucene.queryparser.flexible.standard.parser.StandardSyntaxParser;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.mockito.Answers;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/259")
@FetcherTest
class CollectionOfComputerScienceBibliographiesFetcherTest {
private CollectionOfComputerScienceBibliographiesFetcher fetcher;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/jabref/logic/net/URLDownloadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ public void downloadToTemporaryFilePathWithoutFileSavesAsTmpFile() throws IOExce

@Test
public void downloadToTemporaryFileKeepsName() throws IOException {
URLDownload google = new URLDownload(new URL("https://github.com/JabRef/jabref/blob/main/LICENSE.md"));
URLDownload google = new URLDownload(new URL("https://github.com/JabRef/jabref/blob/main/LICENSE"));

String path = google.toTemporaryFile().toString();
assertTrue(path.contains("LICENSE") && path.endsWith(".md"), path);
assertTrue(path.contains("LICENSE"), path);
}

@Test
Expand Down
Loading