Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JavaDoc to annotation #10571

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Change JavaDoc to annotation #10571

merged 2 commits into from
Oct 25, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 24, 2023

(Time ran out, but better something than nothing)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Oct 24, 2023
@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. The issues found can be automatically fixed. Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. We use Gradle Modernizer Plugin to ensure "modern" Java coding practices. Please fix the detected errors, commit, and push.

You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "Modernizer".

@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@koppor koppor changed the title Change JavaDoc to annoation (and fix visibility) Change JavaDoc to annoation Oct 24, 2023
@koppor koppor mentioned this pull request Oct 24, 2023
Merged
6 tasks
@koppor koppor changed the title Change JavaDoc to annoation Change JavaDoc to annotation Oct 24, 2023
@Siedlerchr
Copy link
Member

Why is deployment broken for mac?

@calixtus
Copy link
Member 

2023-10-24 14:09:31.463 productbuild[4758:24231] CMS signature encoding failed: The timestamp service is not available. (-67885)

@calixtus
Copy link
Member

Has probably nothing to do with JabRef

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit afb9e76 Oct 25, 2023
17 checks passed
@Siedlerchr Siedlerchr deleted the add-visiblity-annotation branch October 25, 2023 13:00
Siedlerchr added a commit to JonathanRech/jabref that referenced this pull request Oct 26, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/Main' into fix-for-issue-10569
1006f22 
* upstream/Main:
  openrerwrite
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  Replace "fixes" by "resolves"
  Change JavaDoc to annotation (JabRef#10571)
  Fix link (JabRef#10575)
  Enable collecting GitHub build artifacts for forks (JabRef#10574)
  Fix file field merging (JabRef#10573)
  Update .gitignore
Siedlerchr added a commit to guipmenezes/jabref that referenced this pull request Nov 1, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-10124
1e1347e 
* upstream/main: (419 commits)
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607)
  Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602)
  Update README.md (JabRef#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (JabRef#10587)
  Add button for a user to reset the cite command to the default value. (JabRef#10580)
  openrerwrite
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  Replace "fixes" by "resolves"
  Change JavaDoc to annotation (JabRef#10571)
  Fix link (JabRef#10575)
  Enable collecting GitHub build artifacts for forks (JabRef#10574)
  Fix file field merging (JabRef#10573)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java
#	src/main/java/org/jabref/logic/importer/WebFetchers.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @Siedlerchr @calixtus