Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2573 support biblatex date formats #10511

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Issue 2573 support biblatex date formats #10511

merged 4 commits into from
Oct 19, 2023

Conversation

XiaotongHe123
Copy link
Contributor

@XiaotongHe123 XiaotongHe123 commented Oct 17, 2023 •
edited
Loading

Fixes #2753
This pull request contributes to #2753.

  • Parse the TODO list of date formats in Date.java class.
  • Tests added.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot this really looks great.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 18, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 19, 2023
Merged via the queue into JabRef:main with commit b1f03e7 Oct 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support all BibLaTeX date formats for parsing
2 participants
@XiaotongHe123 @Siedlerchr