Search results dialog show an empty table of search results

[HoussemNasri]

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

JabRef 100.0.0 Windows 10 10.0 amd64 Java 18.0.2 JavaFX 19+11

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Type something in the global search bar
2. Click the "search across libraries in a new window" button beside the search bar
3. It shows an empty table even though the search algorithm has found 208 results

Note: JabRef 5.8--2022-08-10--dcec4e2 behaves normally

[Siedlerchr]

Very odd! I debugged a bit and found that the problem is here

jabref/src/main/java/org/jabref/gui/search/SearchResultsTableDataModel.java

Lines 36 to 40 in 1e34797

	ObservableList<BibEntryTableViewModel> entriesViewModel = FXCollections.observableArrayList();
	for (BibDatabaseContext context : stateManager.getOpenDatabases()) {
	ObservableList<BibEntry> entriesForDb = context.getDatabase().getEntries();
	List<BibEntryTableViewModel> viewModelForDb = EasyBind.mapBacked(entriesForDb, entry -> new BibEntryTableViewModel(entry, context, fieldValueFormatter));
	entriesViewModel.addAll(viewModelForDb);

getEntries() is an emptyList for some reason the database object returned from the context does not contain any entries...

[HoussemNasri]

I did some experiments and I'm positive this commit f7648e8 introduced the bug. Gone through the changes but I can't seem to spot anything that might cause the bug. I'm really confused!

[Siedlerchr]

@HoussemNasri Yes, very odd 507a263 is the last commit that works.

[HoussemNasri]

For me it's the one just before f7648e8

[Siedlerchr]

I tested a bit more and found out it must have been something to do with loading the last open libraries.
Create a new library with some entries
Search for something
Global search works and shows entry

[Siedlerchr]

I found the problem together with Houssem.
When we load a library we create a new "empty" LIbraryTab and DatabaseContext before the data is fully loaded.
Then we replaced the original bibDatabaseContext with the new one from the parser Result.
However, in stage manager the original list still contains the original databaseContext.