Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "custom colors" window for group color selection loads theme partially #7481

Closed
1 task done
wwtan opened this issue Mar 1, 2021 · 2 comments · Fixed by #7520
Closed
1 task done

The "custom colors" window for group color selection loads theme partially #7481

wwtan opened this issue Mar 1, 2021 · 2 comments · Fixed by #7520
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui

Comments

@wwtan
Copy link

wwtan commented Mar 1, 2021 •
edited
Loading

JabRef version 5.3--2021-03-01--cfb504c on Windows 10 10.0 amd64

Steps to reproduce the behavior:

  1. Create new group
  2. Under "Color", choose "Custom Color..."
  3. And we see the mix-theme window
    2021-03-01 22_44_58-_Mendeley-link bib – JabRef
@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui labels Mar 3, 2021
@Siedlerchr
Copy link
Member

Thanks for the report. The Dark.css needs to be modified to add css for the ColorPicker dialog.
I used scenic view to display the hierarchy, the style class is controls-pane
grafik

@tp-1000
Copy link
Contributor

tp-1000 commented Mar 12, 2021

May I have this one? And is this the preferred way to request an issue?

tp-1000 added a commit to tp-1000/jabref that referenced this issue Mar 12, 2021
@tp-1000
Extends dark theme to group custom-color-picker
fdd8547 
Resolves issue JabRef#7481
Color fix

Dark.css update to extend to the custom color picker
Custom-color-picker background was white instead of dark

Custom-color-picker background is now dark and matches dark theme
@tp-1000 tp-1000 mentioned this issue Mar 12, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui
Projects
Bugs
Archived in project
JabRef UI Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extends dark theme to group custom-color-picker tp-1000/jabref
3 participants
@Siedlerchr @wwtan @tp-1000