Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right click menu for main table header #6601

Closed
mo0ep opened this issue Jun 8, 2020 · 11 comments · Fixed by #9271
Closed

Add right click menu for main table header #6601

mo0ep opened this issue Jun 8, 2020 · 11 comments · Fixed by #9271

Comments

@mo0ep
Copy link

mo0ep commented Jun 8, 2020

It would be nice if right-clicking on the main table header (where the column names are), provided a menu which either allowed to edit the viewed columns/fields directly or provided a link to the preferences.

Maybe a list of the currently and most commonly used fields would show up to be activated/deactivated in the right click menu and for more detailed adjustments a reference to the settings would be displayed.

@calixtus
Copy link
Member

Just for some inspiration: This is how it works in the windows explorer:
image
image

@sj30001
Copy link

sj30001 commented Mar 28, 2021

Hi, we are a group of 5 students from Adelaide University. Our software process improvement class asked us to contribute to an open-source project. We'd love to help with this issue. Is anyone currently working on this issue? If not can we take it? We are all new contributors to open-source projects. If possible could we get some guidance on which part of the code we should look into first. Thanks a lot
Zijian

@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 28, 2021

@sj30001 Thanks for your interest in JabRef. Currently no one is working on this issue.
The TableView code is in the MainTable class under jabref.gui.maintable
For requesting a context menu, some inspiration how this coud be achieved https://stackoverflow.com/questions/59650736/how-to-add-a-context-menu-on-unused-column-header-in-tableview

more info on context menu:
https://o7planning.org/11115/javafx-contextmenu

@team10-h
Copy link

team10-h commented Aug 3, 2021

Hello, we are a group of 8 students from Harbin Institute of Technology from China. Our Open Source Software Development class asked us to contribute to an open-source project. We chose this issue among the projects provided by Mr.Treude and we are interested in helping with this issue. Is anyone currently working on this issue? If not can we take it? We are all new contributors to open-source projects. If we make some mistakes, if possible would you please point it out? Thank you very much.

@calixtus
Copy link
Member

calixtus commented Aug 3, 2021

Hi, thanks for your interest in JabRef. Your teacher already announced your team, so you are free to take it.
Please be aware that there has already been an approach to fix this back in may. So most of to rationale and a part of the solution can be found there. Please make sure you read and understand the discussion in #7729 .
If you have questions, we are happy to answer them. Happy coding!

@ShaunChang
Copy link

Hello, I am a student who comes from study team 6 at Adelaide University. Due to our course Open Source Software Development requirements, our team is focusing on contributing to an open-source project. After discussion, our team agreed that this project is a really excellent open-source project. At the same time, we are very interested in # 6601 this issue and are willing to make positive contributions. We expect to finish this issue and submit our PR before June. Can we work on this issue? If we can, we would appreciate that if you can give us some advice about how to contribute to this issue. Looking forward to your feedback sincerely.

@calixtus
Copy link
Member

Yes you are welcome to dive into this issue. Please prepare your workspace according to our dev docs and please read the discussion at #7729 .
Remember: solution rationale is to add/ remove columns to the maintable, not to alter the visibility property of columns.

Have fun coding. Please make a draft pr as soon as possible, even when you are not finished, so we can follow your changes and help early, if there is something not understood. Feel free to use the Gitter chat to ask questions, if you got any.

@ThiloteE ThiloteE changed the title Right click menu for main table header Add right click menu for main table header Jul 16, 2022
@ethantr
Copy link
Contributor

ethantr commented Oct 11, 2022

Is this issue still being worked on? I've noticed a few other students have looked at it and unsure if it's still taken.
If not, I would love take a look at this for a university assignment.

@calixtus
Copy link
Member

Seems like it's still open and I don't see anybody else working for it. Give it a shot. 👍
Please give attention to #6601 (comment)

@ethantr
Copy link
Contributor

ethantr commented Oct 17, 2022

Been making progress on this issues. I have been able to access the currently used columns, but my current problem is being able to create objects of the most commonly used columns. Just wondering if there is a way to access/create these MainColumn objects so if they're not currently in the MainTabke I can still access them.

@calixtus
Copy link
Member

Just modify or overload the constructor of the MainTableColumnFactory to make it a bit more generic, for instance instead of accessing directly the columnPreferences just provide a column type to recive a perfectly useable MainTableColumn. If you use the column objects in the Right Click Menu you can probably just add them by demand to the column list of the MainTable. But I would not advise you to use the MainTableColumn objects in the Right Click Menu, but just column types (MainTableColumnModel.Type) to avoid useless overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment