Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow merging of year and date if identical #6224

Closed
JoKalliauer opened this issue Mar 31, 2020 · 7 comments · Fixed by #6434
Closed

allow merging of year and date if identical #6224

JoKalliauer opened this issue Mar 31, 2020 · 7 comments · Fixed by #6434
Labels
cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@JoKalliauer
Copy link
Contributor

JoKalliauer commented Mar 31, 2020

JabRef 5.1--2020-03-23--67daf36
Windows 10 10.0 amd64 
Java 14
% Encoding: UTF-8

@Article{morgenthal2016Concretehingesandintegralbridgepiers,
  author       = {Morgenthal, Guido and Olney, Peter},
  title        = {Concrete hinges and integral bridge piers},
  year         = {2016},
  month        = jan,
  number       = {1},
  pages        = {06015005},
  volume       = {21},
  date         = {2016-01},
  doi          = {10.1061/(ASCE)BE.1943-5592.0000783},
  file         = {:Shared/Literatur Betongelenke/Morgenthal_2015_Concrete Hinges and Integral Bridge Piers.pdf:PDF},
  groups       = {FEMPaper, Betongelenke},
  journaltitle = {Journal of Bridge Engineering},
  keywords     = {rank3},
  owner        = {jkalliau},
  publisher    = {American Society of Civil Engineers},
  ranking      = {rank3},
  timestamp    = {2020-03-26},
}

@Comment{jabref-meta: databaseType:biblatex;}

Steps to reproduce the behavior:

  1. open bibtex2biblatexBugJK.bib.txt
  2. clean up using following settings
    Screenshot 2020-03-31 18 57 27

year does not get removed

@tobiasdiez tobiasdiez added cleanup-ops type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 31, 2020
@catarinagomespt
Copy link
Contributor

Hi,
I would like to contribute to your project.
Is this issue still open, right?

Best regards

@catarinagomespt
Copy link
Contributor

I'd like to collaborate on this issue. I would like additional tips to understand better the problem.

@JoKalliauer
Copy link
Contributor Author

@catarinagomespt
I'm just a stupid user, so I might be wrong:

Afaik everyone can make a personal fork and edit this fork and then make a pull request to merge your input (afaik, even if the masterbrach changed meanwile)
No one else claimed to start on this issue and it was marked as low priority (which imho means the user can wait for several month-years for a bugfix), therefore it is highly unlikely someone else will fix this issue within the next month. ("Nobody" cared about it the last month, so the following might be the same.)

@ Developers: I know you are volenteering and I'm glad that you developed JabRef. (So don't understand that wrong. I like JabRef, otherwise I would not use it.)

Do you need tips from the developers (code) or from the problem?

I cannot comment on the code, where to look for.

The problem is:

@Article{bibtexkey,
  year         = {2020},
  month        = may,
}

converts to

@Article{bibtexkey,
  date         = {2020-05},
}

but

@Article{bibtexkey,
  year         = {2020},
  month        = may,
  date         = {2020-05},
}

stays the same, and leads to warnings in biber

@Siedlerchr
Copy link
Member

Some more background information.
JabRef supports bibtex and biblatex (successor of biblatex). However, biblatex uses the date field and not year month like in bibtex. JabRef therefore threats them as alias fields to allow conversion to biblatex and bibtex
The cleanup in jabref should now offer the possibility to merge the year and month field into date and additionally remove/clear the fields afterward.
Code wise I suggest looking into the Cleanup classes in logic

@catarinagomespt
Copy link
Contributor

catarinagomespt commented May 6, 2020

Do you need tips from the developers (code) or from the problem?

Thanks @JoKalliauer . I want to understand the problem not the code. I already realized the problem 👍
That was it! Perfect. I also like to thank @Siedlerchr 's feedback.
I will analyze the code.

@tobiasdiez
Copy link
Member

Thanks to @catarinagomespt this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@JoKalliauer
Copy link
Contributor Author

Thanks to @catarinagomespt : As the author I want to confirm that it is fixed in:

JabRef 5.2--2020-09-04--3db4313
Linux 5.4.0-42-generic amd64 
Java 14.0.2

koppor pushed a commit that referenced this issue Sep 15, 2022
201e022 Update trends-journals.csl (#6224)
46e6eed Update nottingham-trent-university-library-harvard.csl (#6220)
684bb48 Update politix.csl (#6199)
c484b0b Update mcgill-fr.csl (#6198)
cbcf2f2 Update mary-ann-liebert-vancouver.csl (#6218)
47174f0 Create journal-of-dairy-research.csl (#6195)
fdd1eac Update harvard-anglia-ruskin-university.csl (#6196)
9e384d6 Create estonian-journal-of-earth-sciences.csl (#6194)
afba9b7 Delete moore-theological-college.csl as per university (#6197)
644549f Create acta-medica-philippina.csl (#6192)
6566114 Update rassegna-degli-archivi-di-stato.csl (#6186)
3509a2f Update universidade-federal-de-sergipe-departamento-de-engenharia-de-… (#6187)
de4845f Update mary-ann-liebert-vancouver.csl (#6213)
16828b6 Update ucl-university-college-apa.csl (#6172)
c08613b Update ucl-university-college-harvard.csl (#6173)
028bad4 Create sociologia-ruralis.csl (#6170)
77d428c Update journal-of-plankton-research.csl (#6169)
92e1022 Update and rename dependent/journal-of-the-national-cancer-institute.… (#6168)
120efb1 Update journal of hearing science
e503477 Create new-harts-rules-the-oxford-style-guide-author-date.csl (#6163)
49ab318 Create the-depositional-record.csl (#6159)
f4f6920 Update and rename laser-and-photonics-reviews.csl to dependent/laser-… (#6165)
d8ca4bc Update united-states-international-trade-commission.csl (#6162)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 201e022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants