Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: maintable: right-click menu: reorder items #6099

Closed
mlep opened this issue Mar 11, 2020 · 12 comments · Fixed by #7952
Closed

UI: maintable: right-click menu: reorder items #6099

mlep opened this issue Mar 11, 2020 · 12 comments · Fixed by #7952
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@mlep
Copy link
Contributor

mlep commented Mar 11, 2020

In JabRef 5.0, when you right-click on an entry of the main table, you get the following menu:
RightClick

Is your suggestion for improvement related to a problem? Please describe.
Some items are not consistently located: the nearby items are unrelated.

Describe the solution you'd like

  • "Attach file" moved in the cluster "Open folder"..."Open URL or DOI"
  • "Merge entries" moved in the cluster "Copy"..."Delete"
@ilippert ilippert mentioned this issue Mar 12, 2020
Closed
@stefan-kolb
Copy link
Member

It depends on how you categorize things, I guess.
If you say the bottom group includes all entry-related actions/changes to an entry it is probably fine as is right now.
Can you elaborate more why you think your grouping is more consistent?

I would vote to keep it as is right now.
@JabRef/developers What do you think?

@stefan-kolb stefan-kolb added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Mar 14, 2020
@koppor
Copy link
Member

koppor commented Apr 3, 2020

  • Cut/Delete feels similar to merge entries (as one entry is deleted)
  • Attach file is similar to Open file

So it would be fine for me to go with the propsoal.

@koppor
Copy link
Member

koppor commented Apr 3, 2020

Refs koppor#410

@mlep
Copy link
Contributor Author

mlep commented Apr 24, 2020

@stefan-kolb Oops, sorry, I did not notice that your asked for my rationale.
But @koppor did it!... 😉

@ilippert ilippert mentioned this issue May 3, 2020
Open
6 tasks
@mlep
Copy link
Contributor Author

mlep commented May 15, 2020

@stefan-kolb I guess the label "status: waiting for feedbak" is not needed anymore.

@stefan-kolb stefan-kolb removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 15, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@mlep
Copy link
Contributor Author

mlep commented Dec 8, 2020

Issue still valid.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@calixtus calixtus added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: stale labels Jun 8, 2021
@JIANGJiaXiu
Copy link

Hi, we are a group of 8 students from Harbin IT. We are going to work on this issue as an assignment of a course. Hopefully we will try to submit a PR before Aug 6th. Any help will be appreciated as all of us are new contributors to OSS. Thanks a lot!
JiaXiu Jiang

@calixtus
Copy link
Member

Thanks for your interest in this issue.
Implementation of this would probably not more than 5 minutes. Important thing is here to present the thought process of why you would chang the order and how.
So before sending a pull request, please provide your rationale.

@JIANGJiaXiu
Copy link

Thanks for your reply!

We agree with @koppor that

  • Cut/Delete feels similar to merge entries (as one entry is deleted)

  • Attach file is similar to Open file

As to Merge entries, we think it should be put between Cut and Delete Entry, since it has similar function as Delete Entry, and its shortcut is similar to Paste and Cut (using ctrl +) .
As to Attach file, it’s an operation to a local file consistent with Open file and Open folder, and, One shall attach a file before he/she opens it.

Moreover, maybe Delete Entry should be converted to Delete entry in order to be consistent with Merge entries.

like this,
E26F91484C069082D73A433C158B86E5

If out rationale is OK, our teammate @rayinfinite will submit a PR.
Thanks!

rayinfinite added a commit to rayinfinite/jabref that referenced this issue Aug 1, 2021
@rayinfinite
Fix for issue JabRef#6099，edit CHANGELOG
6cf3db7
@rayinfinite rayinfinite mentioned this issue Aug 1, 2021
Merged
5 tasks
@mlep
Copy link
Contributor Author

mlep commented Aug 13, 2021

@rayinfinite : thank you for making JabRef UI more consistent!

koppor pushed a commit that referenced this issue Jul 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from e740261..3d3573c
ffe1663 
3d3573c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (#5988)
5de0fbe Update society-of-biblical-literature-fullnote-bibliography.csl (#5913)
04b6c7a Create revue-internationale-durbanisme.csl (#5974)
4a5bfe2 Update biological-reviews.csl (#6116)
957b2bc Update harvard-cite-them-right-no-et-al.csl (#6115)
e836a6c Update harvard-university-of-bath.csl (#6011)
b4a8dd7 Update and rename harvard-cite-them-right.csl to harvard-cite-them-ri… (#6113)
a198884 Update twentieth-century-music.csl (#6110)
81c1619 Update archaeonautica.csl (#5928)
fc46f1d Bump actions/cache from 2 to 3 (#6112)
fab57ed Bump actions/checkout from 2 to 3 (#6111)
519d594 [don't merge] chore: Included githubactions in the dependabot config (#6109)
a8aa898 Update universidade-estadual-de-alagoas-uneal-abnt.csl (#5915)
6191640 Update isnad-dipnotlu.csl (#5909)
d65a6ac Update isnad-metinici.csl (#5910)
830d337 Update technische-universitat-dresden-linguistik.csl (#6097)
81adc43 Update american-society-for-horticultural-science.csl (#6089)
b767623 Create south-african-law-journal.csl (#6092)
215e1e9 Create journal-of-lithic-studies.csl (#6080)
0740f8c Create eunomia-revista-en-cultura-de-la-legalidad.csl (#6095)
f93c809 Create endocrine-journal.csl (#6086)
3fdeb51 Revert "chore: Set permissions for GitHub actions (#6096)" (#6108)
35ebd1e chore: Set permissions for GitHub actions (#6096)
1cb8758 Create journal-fur-medienlinguistik (#6100)
f4b5f7f Update unified-style-sheet-for-linguistics.csl (#6098)
c3f856a Update advanced-materials.csl (#6103)
d1e7576 Bump diffy from 3.4.0 to 3.4.2 (#6107)
9e5e7ab Fix Dev Dynamics (#6099)
7234520 Add CSL style for the journal Developmental Dynamics (#6093)
ba8db05 Create independent style for vox-sanguinis.csl (#6085)
845dee0 Create meta.csl (#6088)
684bc3a Update universite-du-quebec-a-montreal.csl (#6087)
3602c18 Up-date & re-title pour-reussir/dionne (#6043)
0cc6e82 Fix Mainz Geography
cfc4cec Add DOI and fix printing author names in Population and Économie et statistique (#6079)
14e8b1d Update journal-of-neuroimaging.csl (#6084)
2c0e1f1 Update isnad-dipnotlu.csl (#6081)
02fdb9b Merge pull request #6082 from denismaier/patch-ube-muwi-note
9309378 removes default-locale

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 3d3573c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
Features & Enhancements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reordered items in main table right-click menu rayinfinite/jabref
6 participants
@Siedlerchr @koppor @stefan-kolb @mlep @calixtus @JIANGJiaXiu