Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolinked pdf: icon not shown #5831

Closed
mlep opened this issue Jan 15, 2020 · 6 comments
Closed

Autolinked pdf: icon not shown #5831

mlep opened this issue Jan 15, 2020 · 6 comments

Comments

@mlep
Copy link
Contributor

mlep commented Jan 15, 2020

JabRef 5.0-beta.342--2020-01-15--58709e7
Linux 4.9.0-11-amd64 amd64
Java 13.0.2

When JabRef finds automatically the pdf of a reference in the file directory, the icon is not shown in the main table, and the link does not appear in the BibTeX source.

Steps to reproduce the behavior:

  1. Create a new file
  2. In the main file directory (defined in Options -> Preferences -> File -> External file links), put a file named test20.pdf
  3. Create a new article entry
  4. set the bibtexkey as "test20"
  5. go to the "General tab"
    The linked file appears in the file field:
    Capture du 2020-01-15 14-34-35
    In the BibTeX source tab, the file field is absent:
    Capture du 2020-01-15 14-39-51
    In the main table, the file link icon is absent:
    Capture du 2020-01-15 14-37-00

Note: log file is empty

@Siedlerchr
Copy link
Member

Are you aware that you have to click on the icon in the tab to "accept" the file?

@mlep
Copy link
Contributor Author

mlep commented Jan 15, 2020

No, I did not know. Completely not obvious!

Why do I have to click? If a confirmation was needed, I would have expected a message to be prompted.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 15, 2020

The Autolink in the entry editor/general tab is just a "suggestion". The user has to click the briefcase icon to confirm the choice. There should also be a tooltip. Unfortunately, our existing help/user documention at docs.jabref.org is out of date.
We don't add it automatically as it could overwrite another previously existing file of the user.
This feature has been in JabRef since v4.0

@mlep
Copy link
Contributor Author

mlep commented Jan 15, 2020

I realize I had the same issue with JabRef 4.0. And since all that time I did not know about this briefcase icon...

To me, prompting a message would be better than documentation.
And if no previously-existing link is present in the entry, there is no risk at overwriting anything. So the link could be added without prompting anything.

@tobiasdiez
Copy link
Member

I agree that the briefcase icon is not self-explanatory and the UI in this regard needs improvement. This is however already tacked in #3607.

@mlep
Copy link
Contributor Author

mlep commented Jan 17, 2020

Thanks for pointing to issue #3607! (I did not find it...)

koppor pushed a commit that referenced this issue Jan 15, 2022
5563ccc Update american-society-for-microbiology.csl (#5842)
19ab80f Merge pull request #5843 from POBrien333/patch-1002
d4a6c6d double trouble
424f7fe in-text >> superscript for T&F ACS style
605253c Merge pull request #5837 from POBrien333/patch-998
eb5417d Merge pull request #5838 from alessandro-gentilini/patch-1
7d2d3f5 Fix typo
9f557b5 Re-indent CSL styles
f587e60 polyglot style
3a3fe2c Create journal-fur-kulturpflanzen-journal-of-cultivated-plants.csl
cb24633 Merge pull request #5826 from dstark/patch-7
2590a6c Merge pull request #5833 from POBrien333/patch-997
5b2481e Create nist-techpubs-jres.csl (#5756)
d2a1a49 Re-indent CSL styles
42c51d1 Update tyndale-bulletin.csl
8dae693 rework style
070586b Localize IEEE dates (#5835)
588fbfe Hopefully fix sorting in CSE author-date (#5834)
1291d72 Update physiotherapy-theory-and-practice.csl
1a64076 New Style for "Neue Kriminalpolitik (Deutsch)" (#5586)
eac93a0 Create physiotherapy-theory-and-practice.csl
2e7a9f6 Merge pull request #5832 from POBrien333/patch-996
4dfad5f Update administrative-science-quarterly.csl
f56db0f Merge pull request #5829 from benthamite/patch-1
526b0b3 Update effective-altruism-wiki.csl
e5b11eb Update effective-altruism-wiki.csl
f2a7301 Update effective-altruism-wiki.csl
5b166c2 Update university-of-roehampton-harvard.csl (#5831)
b231514 Update european-society-of-cardiology.csl (#5519)
dbd902c Re-indent CSL styles
fe8892b Update effective-altruism-wiki.csl
734fa7d Update effective-altruism-wiki.csl
2430a32 Create effective-altruism-wiki.csl
a5101b6 update modern-pathology.csl (#5828)
16f77c8 Update tyndale-bulletin.csl
ea8804e Create the-korean-journal-of-mycology.csl (#5822)
22d8be0 Patch 3 (#5825)
0220ba2 Create jcom.csl (#5819)
cd7b72b Create taylor-and-francis-council-of-science-editors-numeric.csl (#5824)
0033383 Create gomis-senegalese-medicine-thesis.csl (#5774)
b221bcc Create mycobiology.csl (#5821)
d7056f9 Re-indent CSL styles
04ae08b Update tyndale-bulletin.csl
24bd577 Re-indent CSL styles
e08d431 clean up logging
f6ac2a6 Update tyndale-bulletin.csl
e4c07f8 this should be the PR repo name
7f9936c fetch pull request from originating repo
f232f51 Update tyndale-bulletin.csl
e2ae4fc Update tyndale-bulletin.csl
f09f8db Update Sheldon to csl-styles 2.0
a4d7dec re-indent style
a903664 sheldon
7db75fc sheldon
f08dc96 sheldon
35b8bfa sheldon
04e28ca pull req checkout
9c9d061 pull req checkout
9249490 sheldon reindent
9792be6 sheldon reindent
3bced06 reindent & commit
7cc9735 Update styles README and GitHub Actions with 1.0.2 information (#5803)
205c4ea remaining dependents
9458056 fix broken styles
07ba7af fix dependents
e2e7842 Fix term hacks for transition to CSL 1.0.2 (#5801)
5c8c5e9 Replace "sub verbo" with "sub-verbo" (#5799)
7ec637c Fix CSL styles
bcd3054 update to csl/citeproc-ruby 2.0
ec13830 bundle update

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 5563ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants