Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No order of items in content selectors #3791

Closed
1 task done
Holzhauer opened this issue Mar 1, 2018 · 9 comments · Fixed by #7458
Closed
1 task done

No order of items in content selectors #3791

Holzhauer opened this issue Mar 1, 2018 · 9 comments · Fixed by #7458
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@Holzhauer
Copy link

Holzhauer commented Mar 1, 2018

JabRef version 4.1

Steps to reproduce:

  1. Add a number of entries to JabRef
  2. Go to General > Keyword and type
  3. You'll see a list of unsorted keywords that make it hard to pick a particular one

jabref4-1_selectors

Alphabetical order would be great.

@stefan-kolb
Copy link
Member

stefan-kolb commented Mar 1, 2018

@JabRef/developers @Holzhauer This is auto-completion functionality? Or are you using the the manage keywords functionality? Btw: this is neatly hidden in edit. i didn't find it without searching the source code. Expected it under options as the other manage dialogs

@stefan-kolb
Copy link
Member

Ok this keyword manage dialog does not dunction as exptected. Shows different keywords for different selected entries sometimes non. adding does only partially work for me...

@jkrenz
Copy link

jkrenz commented Sep 19, 2019

I just updated to a newer JabRef version on my new Mac (4.3.1). I think the problem still exists and it's horrible! I have over 100 passwords, so it's very time-consuming to add new entries to the database now. With the (very) old version I was using on my old mac it worked fine and I also found it much easier to add new keywords (you could do it from the entry).

@koppor
Copy link
Member

koppor commented Sep 20, 2019 via email

@AEgit
Copy link

AEgit commented Sep 21, 2019

JabRef 5.0-dev
Linux 5.0.0-29-generic amd64
Java 11.0.4

Cannot confirm this issue for the current dev snap version. No selection menu at all is shown (indeed, I thought the autocompletion feature had been removed for the time, because it caused too many issues?).

@jkrenz
Copy link

jkrenz commented Sep 23, 2019

Problem still persists in JabRef 5.0 for Mac. Keywords not in alphabetical order, neither when I want to add a new keyword ("Manage content selectors") nor when I want to choose a keyword for an entry.

Bildschirmfoto 2019-09-23 um 10 20 22
Bildschirmfoto 2019-09-23 um 10 21 41

@jkrenz
Copy link

jkrenz commented Sep 26, 2019

Can anyone tell me which Jabref (for mac) version was the last one where the alphabetical order worked and where I can find it?

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 2, 2020
@BJaroszkowski
Copy link
Contributor

I was not able to confirm the issue when selecting a keyword for an entry - the list seems to be in alphabetical order whether the autocomplete is on or off. It is true however, that the keywords were stored in Content Selectors and displayed in Content Selector Manager in the order in which they were added rather than the alphabetical one. I fixed that by simply sorting the list whenever new entry is added. Additionally, I wrote tests for both ContentSelectorSuggestionProvider and ContentSelectorDialogViewModel (as they did not exists) that check among other things that the keywords are in alphabetical order. Is it OK for me to create a pull request?

@Siedlerchr
Copy link
Member

Thanks for taking a look and fixing this issue! Go ahead with a pull request, so we can have a look at your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants