New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable renaming settings files #95

Open

1 of 3 tasks

tpitkanen opened this issue Nov 22, 2020 · 0 comments

Labels

Member

tpitkanen commented Nov 22, 2020 •

edited

Loading

Being able to rename settings files increases the complexity of code without providing much value for users. Issues caused by this feature:

settings files sometimes end up getting duplicated after naming (with both old and new names)
if there are multiple files of the same type, only the first file returned by the filesystem is used
finding settings files requires its own logic
all filetype information must be saved in the extension part because the filename can be whatever

Steps for phasing out settings renaming:

disable name field in settings dialogs
remove code for renaming settings files
change naming format (e.g. "Default.measurement" -> "measurement.json")

tpitkanen added the enhancement label

tpitkanen added a commit that referenced this issue


          Disable name fields for settings (#95)

9b7e3af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment