Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Registration Visitor initialization #54

Merged
merged 3 commits into from
Jun 7, 2017

Conversation

JSkimming
Copy link
Owner

Closes #31

@JSkimming JSkimming self-assigned this Jun 5, 2017
@codecov-io
Copy link

codecov-io commented Jun 5, 2017

Codecov Report

Merging #54 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   99.94%   99.94%   +<.01%     
==========================================
  Files          60       60              
  Lines        1686     1755      +69     
  Branches      317      330      +13     
==========================================
+ Hits         1685     1754      +69     
  Misses          1        1
Impacted Files Coverage Δ
.../Visitors/PropertyDependencyRegistrationVisitor.cs 100% <100%> (ø) ⬆️
src/Abioc/Composition/RegistrationComposition.cs 100% <100%> (ø) ⬆️
...ors/TypedFactoryRegistrationVisitor.WithContext.cs 100% <100%> (ø) ⬆️
...mposition/Visitors/SingletonRegistrationVisitor.cs 100% <100%> (ø) ⬆️
...n/Visitors/SingleConstructorRegistrationVisitor.cs 100% <100%> (ø) ⬆️
...Visitors/FactoryRegistrationVisitor.WithContext.cs 100% <100%> (ø) ⬆️
src/Abioc/Composition/VisitorManager.cs 100% <100%> (ø) ⬆️
...sition/Visitors/TypedFactoryRegistrationVisitor.cs 100% <100%> (ø) ⬆️
...Composition/Visitors/FactoryRegistrationVisitor.cs 100% <100%> (ø) ⬆️
...n/Visitors/InjectedSingletonRegistrationVisitor.cs 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20aa87...f702a1a. Read the comment docs.

@JSkimming JSkimming force-pushed the registration-visitor-initialization branch 3 times, most recently from 14f0b78 to 83e53db Compare June 6, 2017 14:58
@JSkimming JSkimming force-pushed the registration-visitor-initialization branch 2 times, most recently from 8266bae to b9cf91e Compare June 6, 2017 18:09
@JSkimming JSkimming force-pushed the registration-visitor-initialization branch from b9cf91e to f702a1a Compare June 7, 2017 16:27
@JSkimming JSkimming merged commit 9acd237 into master Jun 7, 2017
@JSkimming JSkimming deleted the registration-visitor-initialization branch June 7, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants