Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exception handling simpler #20

Merged
merged 7 commits into from
Sep 26, 2017
Merged

Conversation

JSkimming
Copy link
Owner

Issue #18 has requested better documentation on how to log exceptions. Looking at this, it's relatively complicated when having to implement the three methods of IAsyncInterceptor.

This PR is an investigation into a potentially easier solution.

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines         175    229   +54     
  Branches        3      7    +4     
=====================================
+ Hits          175    229   +54
Impacted Files Coverage Δ
...ore.AsyncInterceptor/ProcessingAsyncInterceptor.cs 100% <ø> (ø) ⬆️
...stle.Core.AsyncInterceptor/AsyncInterceptorBase.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7996e...b8c6a4b. Read the comment docs.

@JSkimming JSkimming force-pushed the simplify-exception-handling branch 3 times, most recently from 6860e42 to fd8b5d2 Compare September 21, 2017 14:25
@JSkimming JSkimming merged commit 24d79c6 into master Sep 26, 2017
@JSkimming JSkimming deleted the simplify-exception-handling branch September 26, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants