Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOML 1.10.7 no longer works with OSGI #351

Closed
nroduit opened this issue Jul 28, 2024 · 1 comment
Closed

JOML 1.10.7 no longer works with OSGI #351

nroduit opened this issue Jul 28, 2024 · 1 comment
Labels
bug
Milestone
1.10.8 release

Comments

@nroduit
Copy link

nroduit commented Jul 28, 2024

The packaging of version 1.10.7 has lost the information needed to work with OSGI. Following this change, it is no longer possible to have JOML directly as an OSGI bundle.

MANIFEST.MF 1.10.7:

Manifest-Version: 1.0

MANIFEST.MF 1.10.5:

Manifest-Version: 1.0
Created-By: Maven Jar Plugin 3.2.0
Build-Jdk-Spec: 11
Implementation-Title: JOML
Implementation-Version: 1.10.5
Implementation-Vendor: JOML
Bundle-ManifestVersion: 2
Bundle-Name: JOML
Bundle-SymbolicName: org.joml
Bundle-Version: 1.10.5
Export-Package: org.joml,org.joml.sampling
Implementation-Build: 82538cc2678d60e5716292e0a58ff8dec7cc8cec
httpdigest added a commit that referenced this issue Jul 28, 2024
@httpdigest
Bring back OSGi support (#351)
daed513 
it was accidentally dropped when switching from Maven to Gradle.

Also include Git Commit SHA again in MANIFEST 'Implementation-Build' attribute.
@httpdigest httpdigest added the bug label Jul 28, 2024
@httpdigest httpdigest added this to the 1.10.8 release milestone Jul 28, 2024
@httpdigest
Copy link
Member

Sorry about that. A new release 1.10.8 has been published and will be ready on Maven Central within the next few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.10.8 release
Development

No branches or pull requests
2 participants
@nroduit @httpdigest