Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternionf fromAxisAngleDeg angle parameter description discrepancy #342

Closed
NicBOMB opened this issue Aug 1, 2023 · 1 comment
Closed

Quaternionf fromAxisAngleDeg angle parameter description discrepancy #342

NicBOMB opened this issue Aug 1, 2023 · 1 comment
Labels
bug documentation
Milestone
1.10.6 release

Comments

@NicBOMB
Copy link
Contributor

NicBOMB commented Aug 1, 2023

Quaternionf fromAxisAngleDeg is described as:

JOML/src/main/java/org/joml/Quaternionf.java

Lines 972 to 973 in 75d60fd

* Set this quaternion to be a representation of the supplied axis and
* angle (in degrees).

and it does convert angle to radians, but its parameter description reads:

JOML/src/main/java/org/joml/Quaternionf.java

Line 982 in 75d60fd

* the angle in radians

@httpdigest httpdigest added this to the 1.10.6 release milestone Aug 2, 2023
@httpdigest
Copy link
Member

Thanks for pointing it out!

httpdigest added a commit that referenced this issue Aug 2, 2023
@httpdigest
Fix Quaternion.fromAxisAngleDeg() angle parameter JavaDocs (#342)
52c7d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
1.10.6 release
Development

No branches or pull requests
2 participants
@httpdigest @NicBOMB