Rectangle.contains produces incorrect results

[BenjaminAmos]

The Rectangle.contains methods appear to be using some subtly incorrect logic. Currently it is:

JOML/src/org/joml/Rectangled.java

Line 337 in 3d21201

return x >= minX && y >= minX && x < maxX && y < maxY;

JOML/src/org/joml/Rectanglef.java

Line 330 in 3d21201

return x >= minX && y >= minX && x < maxX && y < maxY;

JOML/src/org/joml/Rectanglei.java

Line 297 in 3d21201

return x >= minX && y >= minX && x < maxX && y < maxY;

But it should be:

return x >= minX && y >= minY && x < maxX && y < maxY; 

The y >= minX part is incorrect, as it is comparing separate axes together, which was probably not intended. This leads to incorrect results being produced.

The following test case should reproduce the issue:

public class RectangleContainsTest extends TestCase {
    public static void testContainsWithInsidePoint () {
        Rectangled testA = new Rectangled (-5, -10, +5, +10);
        Rectanglef testB = new Rectanglef (-5, -10, +5, +10);
        Rectanglei testC = new Rectanglei (-5, -10, +5, +10);

        assertTrue (testA.contains(+4, -6));
        assertTrue (testB.contains(+4, -6));
        assertTrue (testC.contains(+4, -6));
    }
}

[httpdigest]

Thanks for reporting this! Fix will be up shortly as new 1.9.25-SNAPSHOT version.