Editable combo box editors do not behave like text fields for mouse clicks

[Chrriis]

Hi all!

I find that editable combo boxes do not feel right compared to text fields. The click on the left or right of the text does not edit the text, as indicated by the cursors:

I originally noticed this problem in some custom components that recycle the combo box border, but this is also an issue with regular editable combo boxes. When you want to place your caret at the very beginning of the editable text, it is hard and frustrating because it expands the popup instead of editing the text (e.g. try to place your caret before a "I" for example).

Sample code:

public static void main(String[] args) throws Exception {
	UIManager.setLookAndFeel(new FlatLightLaf());
	JFrame frame = new JFrame();
	frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	JPanel centerPane = new JPanel(new GridBagLayout());
	centerPane.setBorder(BorderFactory.createEmptyBorder(10, 10, 10, 10));
	centerPane.add(new JTextField("Sample text field", 14), new GridBagConstraints(0, 0, 1, 1, 0, 0, GridBagConstraints.WEST, GridBagConstraints.HORIZONTAL, new Insets(0, 0, 0, 0), 0, 0));
	JComboBox<String> combo = new JComboBox<>(new String[] {"Item 1", "Item 2", "Item 3"});
	combo.setEditable(true);
	centerPane.add(combo, new GridBagConstraints(0, 1, 1, 1, 0, 0, GridBagConstraints.WEST, GridBagConstraints.HORIZONTAL, new Insets(10, 0, 0, 0), 0, 0));
	frame.getContentPane().add(centerPane);
	frame.setSize(300, 200);
	frame.setVisible(true);
}

[DevCharly]

Thanks. I agree with you. That do not feel right.

Is also the case for JSpinner.
Will rework it...

[DevCharly]

@Chrriis have reworked internals of combo box and spinner UI delegates.
The internal text field now occupies the whole area within the border.
For not editable combo box, the renderer uses the whole area within the border.

Before:

After:

This affects editors with custom borders (#102) and custom renderers.

Before:

After:

[Chrriis]

I gave it a try, and everything seems to work as expected, even in some awful compositing cases! Thanks! 👍