Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #138 #139

Merged
merged 3 commits into from
Apr 19, 2015
Merged

Issue #138 #139

merged 3 commits into from
Apr 19, 2015

Conversation

abinoam
Copy link
Collaborator

@abinoam abinoam commented Apr 19, 2015

Related to #138

As a fast fix I just reapplied the commit and bumped up the version.

@KrauseFx, could you check if this fix for you before @JEG2 makes a new release?
(I'm not able to reproduce neither the fail nor the fix by now).

fissionxuiptz and others added 2 commits April 19, 2015 00:36
IO.console.winsize returns [ rows, columns ], but terminal_size should return [ columns, rows ]
@KrauseFx
Copy link
Contributor

Thanks for the quick fix!

Sorry, I somehow can't install the version from the issue_138 branch, I cloned and ran bundle install && sudo rake install. Installation works fine, but as soon as a import commander the following is shown:

/Users/felixkrause/.rvm/rubies/ruby-2.0.0-p481/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:135:in `require': cannot load such file -- highline/import (LoadError)

The same in irb:

$ irb
> require 'highline'
LoadError: cannot load such file -- highline
    from /Users/felixkrause/.rvm/rubies/ruby-2.0.0-p481/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'

If I do a gem install highline to install the last official release the require is working fine.

@abinoam
Copy link
Collaborator Author

abinoam commented Apr 19, 2015

Hi @KrauseFx ,

Try rake install without sudo.

Perhaps the use of sudo here could try to install the gem into a multi user rvm install (at /usr/local/rvm, not at ~/.rvm). Not sure. (https://rvm.io/rvm/install)

Any way, I have managed to test it over here with...

ruby -e "require 'commander'; ask('hi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi there')"

... against the 2 versions.

I think is safe for @JEG2 to merge now.

And thanks for reporting the issue.

JEG2 added a commit that referenced this pull request Apr 19, 2015
@JEG2 JEG2 merged commit 578c74b into JEG2:master Apr 19, 2015
@JEG2
Copy link
Owner

JEG2 commented Apr 19, 2015

I'll make a release if @KrauseFx reports this is working…

@KrauseFx
Copy link
Contributor

@abinoam Thanks for the quick fix
@JEG2 Sorry it took so long, but I finally got the gem working. It's working fine and solves the problem 👍

Thank you for you help!

@JEG2
Copy link
Owner

JEG2 commented Apr 19, 2015

I just released the fix.

@KrauseFx
Copy link
Contributor

Thank you @JEG2, really appreciated 👍

mbaltaks pushed a commit to mbaltaks/shenzhen that referenced this pull request Jun 2, 2015
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jun 4, 2015
=== 4.3.4 / 2015-05-03

* Fixed a regression with the compact help formatter.

=== 4.3.3 / 2015-04-21

* Updated to highline 1.7.2 to fix a regression with terminal size (JEG2/highline#139).
* Help formatting updated to look better for commands with long names. (@jszwedko)

=== 4.3.2 / 2015-03-31

* Version bump to publish new location of Commander to Rubygems. Moved to https://github.com/commander-rb/commander

=== 4.3.1 / 2015-03-27

* Fix various Ruby warnings for circular requires, etc.
* Update to use highline 1.7 (@SkyTrix)
@abinoam abinoam deleted the issue_138 branch July 9, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants