Lazy loading is implement #130
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Abhijit25Mishra Please review my pr now |
|
@Abhijit25Mishra Please have a look
|
|
@shraddha761 try showing the difference with and without the changes you made, make note of the stats and observations and write in detail about it. this will actually help the site a lot (from what i know about lazy loading), just try and show some stats to prove it. |
|
@J0SAL please review I have added loading to website |
|
@Abhijit25Mishra can you review |
|
@shraddha761 can you implement it such that only the first time the user visits this page, it will load this animation. you can try using caching for that. also i see that the image gets loaded first then it appers to rotate, this makes it look bad, what you can do is add opacity changes, what i mean is that the start opacity should be zero and at 0.25 second also it should be zero then from 0.25 second to 3 sec, it should gradually increse to 100%. i know it sounds complicated, but its really simple. |
|
@Abhijit25Mishra how to start opacity from 0.25 I tried using delay but it didn't work and for loading for first time user i have used session storage |
|
Yeah I saw that session storage thing in code, I didnt really get why it didn't work. Please check online about opacity, try reading about keyframes. Search on gpt and llaama |
|
@Abhijit25Mishra I have done some changes please review |
|
@J0SAL I didn't understand , you mean to do it from another way |
wait, let me review it again |
| <Loading/> | ||
| <Container className="mt-5 py-3 bg-white"> | ||
| <Suspense fallback={<div>Loading...</div>}> |
There was a problem hiding this comment.
Instead of this can you directly put Loading inside Suspense?
like, <Suspense fallback={<Loading/>}>
|
@J0SAL Please review now |
|
@shraddha761 there weren't any updates in the code |
Resolves #123
Description
Screenshots
Checklist