Lazy loading is added #126
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Abhijit25Mishra can you review this |
|
@J0SAL please review my pr |
Let's wait for @Abhijit25Mishra to review it |
| @@ -24,7 +24,7 @@ export default function App({ Component, pageProps }: AppProps) { | |||
| <meta name="description" content="Made by Joy Almeida" /> | |||
| <link rel="icon" href="/favicon.ico" /> | |||
| </Head> | |||
| <PageNavbar /> | |||
| <PageNavbar /> | |||
There was a problem hiding this comment.
Please note that these type of changes do not get commited. For people for review and merge your code have to spend time and make sure this is correct.
simply put, if you make our job easier the fast things get processed.
| @@ -34,4 +34,4 @@ export default function App({ Component, pageProps }: AppProps) { | |||
| </MoralisProvider> | |||
| </React.StrictMode> | |||
| ); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
same problem over here, how did this even get commited ?
| import PageNavbar from "../components/common/PageNavbar"; | ||
| import Footer from "../components/common/Footer"; | ||
| import DataState from "../context/DataContext/dataState"; | ||
| import { SpeechProvider } from "@speechly/react-client"; | ||
| import { MoralisProvider } from "react-moralis"; | ||
| import { NotificationProvider } from "web3uikit"; | ||
| import React from "react"; |
There was a problem hiding this comment.
details like this (implementation specification) go to the description. Why have you changed this import from line 6 to line 12 ?
|
@Abhijit25Mishra apologize for all this mistake I'll make fresh pr and implement lazy loading properly |
Resolves #123
Description
Add lazy loading to overview, Transactions, PerformanceGraph , Performers
Screenshots
Checklist