Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated prophecy calls and MimeTypeGuesserInterface. #50

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jul 3, 2023

GitHub Issue: Islandora/documentation#2235

What does this Pull Request do?

Removes deprecated calls to prophesize() and uses of the deprecated MimeTypeGuesser. Also declares D10 compatibility.

What's new?

This should make it work in Drupal 10 as it does in Drupal 9.

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Spin it up on Drupal 10 and put a valid Cantaloupe URL in the OpenSeadragon settings. Place a block and feed it a manifest (since the IIIF submodule isn't ready yet) throw a demo manifest URI in the block like https://digital.library.villanova.edu/Item/vudl:92879/Manifest . Verify it shows the content, and no messages in the logs.

Additional Notes:

The tests ran (in a D9 environment) just fine. CI will tell us about Drupal 10.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@alxp alxp merged commit 0ba57c3 into Islandora:2.x Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants