audio captions part 2 #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elizoller, do you have an audio file with a companion caption file I can test with? (I have a bunch of audio, but no time-marked transcriptions yet.) |
modules/islandora_audio/js/audio.js
Outdated
|
|
||
| function init(context,settings){ | ||
| if (!initialized){ | ||
| console.log("hello audio"); |
| @@ -15,14 +15,18 @@ | |||
| * @ingroup themeable | |||
| */ | |||
| #} | |||
| <div id="audioTrack"></div> | |||
| {#<video {{ attributes }} controls poster="http://localhost:8000/sites/default/files/2021-03/1-Service%20File.jpg">#} | |||
There was a problem hiding this comment.
Nit: commented out <video> element.
|
@seth-shaw-unlv i used https://umd-mith.github.io/webvtt-player/annotations.html which @kayakr was testing with previously |
… be set in the track config
|
Yeah.... I totally want that webvtt-player.... |
|
we could go that route if you want, it wouldn't be that hard |
|
As a separate PR. Let's get this merged for now. |
|
ok, sounds good |
IAMlKeno
pushed a commit
to IAMlKeno/islandora
that referenced
this pull request
Aug 11, 2021
* pulling the text track outside of the audio element so its not hidden * do not set default in the template, because its an attribute that can be set in the track config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Provides a solution to DISPLAY the captions for audio files
What's new?
How should this be tested?
Additional Notes:
This spawned out of conversation on #826 with @kayakr
You should see the text of the captions above the audio player like so:
Interested parties
@Islandora/8-x-committers