Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIIF Manifest alter hooks were accidentally deleted #961

Closed
alxp opened this issue Jul 4, 2023 · 0 comments
Closed

IIIF Manifest alter hooks were accidentally deleted #961

alxp opened this issue Jul 4, 2023 · 0 comments

Comments

@alxp
Copy link

alxp commented Jul 4, 2023

We recently merged a change that added alter hooks to the IIIF Manifest Views style plugin so that modules could add things like search annotation endpoints.

Looking at a recent version of the code, these hooks have gone missing. From the looks of things it was likely from having multiple PRs in flight at once.

PR forthcoming.
alxp added a commit that referenced this issue Jul 4, 2023
@alxp
Issue #961: Put back accidentally-removed IIIF Manifest alter hooks.
d9f9df4
@alxp alxp mentioned this issue Jul 4, 2023
Merged
rosiel added a commit that referenced this issue Jul 11, 2023
@alxp @rosiel
Issue #961: Put back accidentally-removed IIIF Manifest alter hooks. (#…
ac818a0 
…962)

* Issue #961: Put back accidentally-removed IIIF Manifest alter hooks.

* Address PHPCS errors.

* Address PHPCS errors.

* Addresss PHPCS errors.

---------

Co-authored-by: Rosie Le Faive <lefaive@gmail.com>
@rosiel rosiel closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alxp @rosiel