September 21, 2022

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. The hosting can be claimed by anybody with the host ID. The Host ID is in the header of the TAG slack channel.

Time: Wednesday, 1:00pm Eastern Time US (UTC-5)
Zoom link: https://zoom.us/j/97345581392
Passcode: 919241
Join us on the Slack Islandora Channel https://islandora.slack.com/archives/CM5PPAV28

Chair Roster

These are the core members of TAG and will take on chair of the meeting if there are no volunteers, and will support volunteers who are chairing for the first time:

Don 🪑
Seth
Rosie
Willow

Attendees

Don Richards (Chair)
Rosie Le Faive
Seth Shaw
Jason Hildebrand
Alexander O'Neill
Jordan Dukart
Annie Oelschlager
Jared Whiklo
Adam Vessey
Marcia Johnson
Rebel Cummings-Sauls
Willow Gillingham
Isabella Nikolaidis (notes)

Agenda

Note that links are to the document repository only. New issues in other repositories or organizations will not appear in this list, and should be added by interested parties directly to the agenda.

Plan for deprecating Islandora Defaults - review Deprecation Announcement Template (larger policy discussion to follow)
Issue Roundup - Link sorted by recently updated
PR Roundup- Link sorted by recently updated
Review of mailing list
Feel free to add more, or add something from Islandora Discussions

Minutes

Plan for deprecating Islandora Defaults

Rosie: Not pushing until ISLE and playbook are merged.
- Any suggestions from those who might have done deprecation in other repositories?
Jason Hildebrand: What is the impact to someone with an existing islandora instance?
Rosie: You shouldn't try to update islandora defualts. It's a feature module.
- If you were to do a composer update, your code version would increase to the latest released version.
- It will show Islandora Defaults and it will show what's changed between the code and your currently loaded configuration.
- Generally, don't load new code over existing configuration.
Seth: Exception - mirador is a submodule of it, and it does have code. If you are using the mirador submodule, Alex is breaking this out as a separate module.
Rosie: Don't try to uninstall because it will remove configuration.
- There will be a communication on what to do if you're an existing site.
- Can we send those instructions before the deprecation announcement?
Comment on the document!
OAI-PMH
- Alexander: Should it no longer exist as it's own module? Part of the starter site?
- Rosie: Took the 2 config sub modules of islandora defaults and put them in islandora starter site.
Seth: Some configs should not be kept there. Make sure you have filters.
Adam: May want to look at moving to other structures to store these things
Don: Drupal podcast

Issue Roundup

https://github.com/Islandora/documentation/issues/2163

Rosie: Documentation needs to be fixed for where mirador is mentioned.
Also needs to be registered in packagist.
- In it's composer.json, will show as incompatible.

https://github.com/Islandora/documentation/issues/2175

Rosie: Our deployment stuff makes the env that the starter site lives on.
- So, when you change the starter site in a way that affects the environment feelers -
  - ex. Introducing a new library, interfacing with an external service,
- We need playbook and ISLE to synchronizedly provide that change to the env to match what the starter site expects.
We've been versioning the playbook using semver which works well for components that rely on each other.
What about for things that don't really have an API (and so semver doesn't work as well with)?
Seth: Does it make sense for starter site to use caliber? Name a release after the month it was released in?
Alex: Thinking of the playbooks, if the playbook was agnostic to what version the starter site was at, but just had a step that says go and get the latest stable verison.
Don: If we need to lock it to a version, we can use dependabot and set it up on ISLE and playbook, so whenever a enw release comes out for that module, it would automatically create a pull request.
Alex: Still have to be mindful of breaking changes but that will be a more manageable frequency of updates.

https://github.com/Islandora-Devops/isle-dc/issues/290

Jason: A bug in the makefile hit when trying to check out the latest ISLE-dc.
- Submitted a PR to fix.
Raises the question: Setting up continuous integration? Would run make targets that we could catch before users hit them.

https://github.com/Islandora-Devops/isle-dc/issues/289

Rosie: It would be cool if the tools did a little ping/notification because they take a while to run.
Alex: If we know where in the codebase it could potentially ask for a root password you could have a little script that runs right before it. If the user has an option flag to notify like a macos hook into the notification centre, or beep.
Adam: You can also preemptively pseudo make whatever

https://github.com/Islandora/controlled_access_terms/issues/86

Rosie: If you make entity relationship field on a node, and make a taxonomy term, when you delete the term, the term will get deleted from a node. This doesn't happen in typed relation fields. It shows up in the html as a label and then just a blank space where there would normally be a taxonomy term. In the devel area of the moudle you can still see the taxonomy term.
Don: Is that feature part of stubs? In migration, you reference a taxonomy term you haven't created yet.
Seth: It's intended that when the migration completes it still be there.
- Never have tested the entity reference. How does Drupal handle that?
Adam: I think it leaves the references intact?
Adam: It also doesn't work with the controlled access terms things that are subclasses of any reference stuff. Only works with the entity references themselves directly.
Seth: If you got to edit the thing that references it, it doesn't display in the list of tags. It's hiding until you edit the thing and then save it again, then it gets rid of it.

https://github.com/Islandora/advanced_search/issues/58

Access token for Mirroring between Github and Gitlab is expired.

Pull Request Roundup

https://github.com/Islandora-Devops/isle-dc/pull/287

Adam: Had to make some other small changes to allow it to run the base mgirations as a particular user so things would end up in fedora from the get go.
- Ready for testing
Don: Do we have the equivalent for playbook?
Adam: Playbook already exists as well, another PR.
Whoever takes this needs to test that everything that the configs touch gets tested.
Alex: Can test on the playbook version.
Adam: On the ISLE side of things, added the bindings of the site in sample .n (?) instead of the default string of default JWT keys.

https://github.com/Islandora/islandora_solution_pack_newspaper/pull/171

Islandora 7 issue - newspaper solution pack.
Have to check if CLA on file - Isabella

https://github.com/Islandora-Devops/islandora-playbook/pull/229

Playbook pull request.
Alexander: Grok is a JP2 decoder that we no longer need to have because we changed it a while ago to use OpenJP2 from Open JPEG. Also, Grok takes a long time to compile and is an old version. So this process speeds things up and nothing changes.
Testing instructions: Make sure mirador runs as usual, cantaloupe can get a JP2, instructions provided in pr.
Don: Tomcat config - is this also going to be in ISLE?
Alexander: Not sure how ISLE does JP2 support.
ISLE runs not on ubuntu, on minimal linux distro (alpine).
Seth: Buildkit is pulling in image magic and openjpeg tools from APK.
Jared to test.

https://github.com/Islandora/islandora/pull/900

Rosie: Problems with the CI for Drupal 9.5
- Something about how they did dependency injection, which changed.
- This code definitely doesn't touch that. Might be something we need to update our code for 9.5, or maybe 9.5 wasn't working?
- Spinning up now at least one of the CI tests that failed to see if it passes now.
- If not, will ping to see if anyone can see what's up with 9.5.
Jared: It's failing on REST UI, and openseadragon when trying to enable those two modules, possibly more, but not related to the code in that. May require more digging to figure out what's going on or maybe wait a week and see if they commit something that fixes it.
Seth: I would merge it regardless of the 9.5 status, because the rest is green for what we currently support.

https://github.com/Islandora/islandora/pull/899

Jared: When you unselect content types from the Fedora URI field it doesn't remove them from all the various things you may have them in.
But also fails on 9.5.
Seth to test.

https://github.com/Islandora/documentation/pull/2105