Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text changes requested during PR Review #2090

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Text changes requested during PR Review #2090

merged 1 commit into from
Apr 13, 2022

Conversation

misilot
Copy link
Contributor

@misilot misilot commented Apr 13, 2022

Purpose / why

Missed changes from #2084

They didn't get merged in to that PR.

What changes were made?

Verification

Interested Parties

@seth-shaw-unlv

Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@seth-shaw-unlv seth-shaw-unlv merged commit 4adecc4 into Islandora:main Apr 13, 2022
@misilot misilot deleted the seth-changes branch April 14, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-unlv seth-shaw-unlv seth-shaw-unlv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misilot @seth-shaw-unlv