Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create homepage.md #1989

Closed
wants to merge 1 commit into from
Closed

Conversation

DonRichards
Copy link
Member

Purpose / why

Docs on how to update homepage based on new changes to islandora/islandora

What changes were made?

Added a new MD file

Verification

Review Changes are accurate based on pull request.

Interested Parties

Pending Pull Request

Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@DonRichards
Copy link
Member Author

Related Pull Request Islandora/islandora#856

@DonRichards DonRichards requested a review from a team November 30, 2021 19:47
@DonRichards DonRichards added the Subject: User Experience Related to a user’s experience with the software. label Nov 30, 2021
@DonRichards DonRichards linked an issue Nov 30, 2021 that may be closed by this pull request
@DonRichards DonRichards changed the title Draft: Create homepage.md Create homepage.md Nov 30, 2021
@DonRichards DonRichards self-assigned this Nov 30, 2021
@mjordan
Copy link
Contributor

mjordan commented Nov 30, 2021

@DonRichards what's the best way to test this?

@DonRichards
Copy link
Member Author

@mjordan This is the docs related to this PR Islandora/islandora#856

This PR needs to go in first for this to be relevant. But basically to test this is to follow the instructions provided by the MD file against the changes made in the pull/856

@mjordan
Copy link
Contributor

mjordan commented Dec 1, 2021

@DonRichards thanks. If this needs to be reviewed by the end of the sprint, it's probably best to have someone who can commit to that timeline to review it. All of my dev/testing time is going into Workbench lately and I can't even keep to my promised timelines on that.

@DonRichards DonRichards deleted the tutorial_homepage branch March 30, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: User Experience Related to a user’s experience with the software.
Development

Successfully merging this pull request may close these issues.

Welcome message on new site
2 participants