Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Gemini lookup text less node-specific. #1080

Closed
wants to merge 2 commits into from
Closed

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Apr 11, 2019

Great to have this available! minor edits? comments welcome.

@Natkeeran

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this as is and will merge it. Just noting that with #124 and #126 we should note the existence and use of the new pseudo fields.

@whikloj
Copy link
Member

whikloj commented May 2, 2019

@rosiel oh there is a conflict, could you rebase or press the "resolve conflicts" button please.

@rosiel
Copy link
Member Author

rosiel commented May 2, 2019

Apparently i entirely wiped out my changes. Hmm.

@rosiel rosiel closed this May 2, 2019
@rosiel rosiel deleted the rosiel-patch-1 branch May 2, 2019 18:49
@rosiel
Copy link
Member Author

rosiel commented May 2, 2019

Well this is super confusing... because apparently my changes were already made with https://github.com/Islandora-CLAW/CLAW/pull/1084/files. No need for this PR!

@whikloj
Copy link
Member

whikloj commented May 2, 2019

Well then, good work 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants