Remove PHP warning by removing array type hint #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: Declaration of Drupal\controlled_access_terms\EDTFConverter::dateIso8601Value(array $data) should be compatible with Drupal\rdf\CommonDataConverter::dateIso8601Value($data) in require() (line 10 of modules/contrib/controlled_access_terms/src/EDTFConverter.php).
|
So, we can't simply remove the array type hint because the Drupal coding standards doesn't like it, even though the CommonDataConverter doesn't have it. Does that mean the rdf module's CommonDataConverter doesn't pass Drupal coding standards? How did that get through? |
|
Okay, regardless of how they got away with using the array in docs but not using the type hint, using the 'mixed' type hint allows us to pass the coding standards and not use a type hint, so no errors! I have another PR incoming that address this and the other issues in Islandora/documentation/issues/1123. Please stand by. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: Declaration of Drupal\controlled_access_terms\EDTFConverter::dateIso8601Value(array $data) should be compatible with Drupal\rdf\CommonDataConverter::dateIso8601Value($data) in require() (line 10 of modules/contrib/controlled_access_terms/src/EDTFConverter.php).