Automated testing #128
Merged
Automated testing #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added automated tests and documentation. - Return the exit code of the service that exited - Previously always returned 0 even if the service failed to start.
|
This changeset is huge. I'll try and smoketest this and see if the tests pass, etc... Also, I see you're getting rid of some more execline 🔥 🥰 |
|
Things are building fine but I'm getting errors when running |
|
Ya you’ll need to login to docker. Wise it downloads etcd to run one of the
tests
On Thu, 1 Apr 2021 at 21:02, dannylamb ***@***.***> wrote:
Things are building fine but I'm getting errors when running ./gradlew
test. Looks like I need to login to docker first?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADW7TMG4SD6UMJGCAOYHCTTGTGNZANCNFSM4Z2KDWMA>
.
--
Nigel Banks
***@***.***
|
|
Okay, works fine once you log in. I've dug through this enough to grasp the general pattern of docker-compose files exec'ing the test commands. |
dannylamb
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automated tests and bumps the plugin to the latest version to get more consistent caching, and to reduce the size of CI builds (so we don't bump against the GitHub limit of around 12~14 GB).
The changes to the plugin should be merged first.
Islandora-Devops/isle-gradle-docker-plugin#8