Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Riprap as a microsevice #113

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Add Riprap as a microsevice #113

merged 3 commits into from
Apr 6, 2021

Conversation

nigelgbanks
Copy link
Contributor

@nigelgbanks nigelgbanks commented Feb 25, 2021 •
edited
Loading

Changes:

  • Adds Riprap micro-service

@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Feb 25, 2021 •
edited
Loading

Opening as a draft until I can attach some working examples using the different database backends, etc. Likely there are bugs that need to be sorted out.

@nigelgbanks
Copy link
Contributor Author

Rebased on #119 as that should be merged first and affects this implementation.

@nigelgbanks
Automated Tests
524ee8a 
- Added automated tests and documentation.
- Return the exit code of the service that exited
- Previously always returned 0 even if the service failed to start.
@nigelgbanks
Bump version of plugin
c64c057
@nigelgbanks
Added Riprap micro-service.
0f2af91
@nigelgbanks nigelgbanks marked this pull request as ready for review March 29, 2021 10:30
@nigelgbanks
Copy link
Contributor Author

This is ready to be reviewed, though it depends on #128 being merged first, if interested in only the RipRap changes look at commit 0f2af91

@nigelgbanks
Copy link
Contributor Author

There is still references to Gemini, though Gemini is not required to run RipRap, when RipRap is updated I'll update this as well.

@nigelgbanks nigelgbanks mentioned this pull request Mar 30, 2021
Merged
@dannylamb dannylamb merged commit d8467eb into Islandora-Devops:main Apr 6, 2021
@nigelgbanks nigelgbanks deleted the riprap branch April 6, 2021 16:47
@nigelgbanks nigelgbanks mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannylamb dannylamb Awaiting requested review from dannylamb

@mjordan mjordan Awaiting requested review from mjordan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigelgbanks @dannylamb