Move facets to footer. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually overwrote it by the view config by going to https://islandora.traefik.me/admin/config/development/configuration/full/import. Then cache cleared and rebuild the index as well. The general search works, but the alignment is off. I've attached a screen shot. However, when navigating to the collections, it does not display the facets as one would expect. |
|
Danny, Nat and I looked at this and it looks good except that the same changes need to be made to this section as well |
This was referenced Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move facet info to the footer of the block. Sorry this took me so long, I tried a million ways that didn't work to get these to show up in the footer. If you have a working site with demo content and the install profile, testing should be as easy as loading this YML through config sync and seeing that the facets start showing at the bottom instead of the top, whenever a search view is rendered.
I don't know that using the "header" and "footer" view regions is the best long term solution for placing facet blocks. I do know that doing it this way makes it a little less theme dependent.
@Natkeeran @kstapelfeldt