Installs PHP 7.2 #95
Installs PHP 7.2 #95
Conversation
|
It appears that RipRap supports PHP 7.1.3 and greater. |
|
True dat, but there doesn't seem to be a way to go higher than 7.1.26 on
Ubuntu without going to 7.2
…On Fri, Feb 22, 2019, 4:21 PM Jared Whiklo, ***@***.***> wrote:
It appears that RipRap supports PHP 7.1.3 and greater
<https://github.com/mjordan/riprap/blob/master/composer.json#L13>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeNJ0pO0LIjEbdfMFH-X2ODEarjPLH2ks5vQFFKgaJpZM4bKTot>
.
|
|
@mjordan can you explain why 7.1.3 is required for RipRap?
…On Fri, Feb 22, 2019, 20:49 Alan Stanley, ***@***.***> wrote:
True dat, but there doesn't seem to be a way to go higher than 7.1.26 on
Ubuntu without going to 7.2
On Fri, Feb 22, 2019, 4:21 PM Jared Whiklo, ***@***.***>
wrote:
> It appears that RipRap supports PHP 7.1.3 and greater
> <https://github.com/mjordan/riprap/blob/master/composer.json#L13>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#95 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAeNJ0pO0LIjEbdfMFH-X2ODEarjPLH2ks5vQFFKgaJpZM4bKTot
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACua4ef-dd-6iqn5S4NLufST9Fi23o88ks5vQKwvgaJpZM4bKTot>
.
|
|
Symfony 4 dependency, https://symfony.com/doc/current/reference/requirements.html. |
|
@seth-shaw-unlv got Riprap to work on the claw-playbook. See mjordan/riprap#20. Not sure how he handled the PHP requirement though. |
|
I know @seth-shaw-unlv is running Centos so maybe it is a better version of
PHP.
I wonder if the php-versions role would accept `7.1.3` as the version?
…On Sat, Feb 23, 2019, 11:22 Mark Jordan, ***@***.***> wrote:
@seth-shaw-unlv <https://github.com/seth-shaw-unlv> got Riprap to work on
the claw-playbook. See mjordan/riprap#20
<mjordan/riprap#20>. Not sure how he handled
the PHP requirement though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACua4XtTe75Q0Ajhmx_Vz740Pqcm8HZ_ks5vQXjogaJpZM4bKTot>
.
|
|
If @ajstanley's PR works, any reason why we shouldn't install PHP 7.2 on the claw-playbook? |
|
Just that it will be tougher to get the minimum PHP version to do things like update composer.lock files and such. We can always just drop 7.1 and roll out with only 7.2+ if folks don't think it's too late. |
|
Looking at this again, |
|
So... is there anything standing in the way of moving to 7.2? |
|
I've found a couple of minor problems - don't merge this one just yet. |
|
Should be good now. |
|
@Islandora-Devops/committers are there any concerns with switching to 7.2? To respond explicitly to @whikloj 's point, which implies that this whole PR isn't necessary, it is necessary because Riprap requires Symfony 4, which requires 7.1.3+ as @mjordan pointed out. |
|
@rosiel It was decided to go with 7.2 at this meeting: https://github.com/Islandora-CLAW/CLAW/wiki/February-27%2C-2019. If we run into any issues, we can deal with them as they arise. |
|
Just to clarify my reasoning.
and finally I just cloned RipRap into an existing claw-playbook instance running PHP 7.1.27, installed it and ran it. I'll note I had to edit the sample_csv_config.yml to point to files accessible to the vagrant machine. |
|
@whikloj Will bumping the flex version riprap uses to |
|
@mjordan Bumping to More information on this version constraint here And yes, the flex PHP requirement is Also, and this is a mea culpa, version |
|
@whikloj thanks for the suggestions on updating riprap. I probably haven't had enough caffeine yet today but is there anything holding us back from using PHP 7.2 in the CLAW vagrant? I am running |
|
@mjordan no, there is no reason why we can't do this. My point is that we would be choosing to drop support for PHP 7.1. There is no technical need, I just want people to be aware of that. When we dropped PHP 5.6 and 7.0 support, the discussion was around Silex deprecation and that Symfony 4 required PHP 7.1. Riprap runs under 7.2, but it also runs in claw-playbook under 7.1. But to the question of what we need to do. Along with this PR, the travis build scripts will need to be updated to remove 7.1 testing for the Drupal modules, Crayfish and Crayfish-Commons. Perhaps we should add in PHP 7.3 for testing. As well someone should send a note out to the community just to keep them informed. |
|
@whikloj your clean explanation is worth more than any amount of caffeine. I get it now. |
|
Testing this now 🚀 |
|
Installed fine. Could verify PHP 7.2 on the command line and went through a basic sanity check. Ingested an image -> gave it an original file -> checked derivatives -> verified fedora, solr, and triplestore indexing. That was for Ubuntu. Didn't try CentOS. I need to use this environment to work through some things, but I'll give CentOS a whirl later just for sanity's sake before merging and doing all the afterwork for this. @seth-shaw-unlv You use 7.2 and CentOS. Do you know if anything special needs to be done? Or does the 7.1 -> 7.2 change in |
|
@dannylamb you need to change it in both webserver.yml and crayfish.yml. |
|
@seth-shaw-unlv Gotcha. Both of those are covered under this PR. |
|
@dannylamb, yeah, that should do it. I can kick off another build if you want. |
|
@seth-shaw-unlv++ That would be awesome. If a CentOS build succeeds we can merge this in. |
|
@dannylamb |
Installs PHP 7.2 to allow the Riprap microservice and module to install.