churn no timeouts fix #4959
Merged
churn no timeouts fix #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mwojtowicz/churn-no-timeouts-fix
branch
from
66bd878
to
1295559
Compare
bolt12
approved these changes
Sep 16, 2024
coot
reviewed
Sep 16, 2024
Comment on lines
+350
to
+353
| let praosSyncTargets = min 1 (targetNumberOfActiveBigLedgerPeers base) | ||
| in case regime of | ||
| ChurnBootstrapPraosSync -> praosSync | ||
| ChurnPraosSync -> praosSync | ||
| ChurnBootstrapPraosSync -> praosSyncTargets | ||
| ChurnPraosSync -> praosSyncTargets |
There was a problem hiding this comment.
We use praosSync in other places. Maybe change it in other places as well?
There was a problem hiding this comment.
I think I renamed most of those to deadlineTargets as under Praos that's all we have and which is modified by stepping thru the churn loop. Here I decided to keep the praosSync prefix instead of renaming the let binding to deadlineTargets as maybe it would be slightly confusing.
| @@ -414,7 +414,7 @@ peerChurnGovernor PeerChurnArgs { | |||
| -> HotValency | |||
| -> PeerSelectionTargets | |||
| -> ModifyPeerSelectionTargets | |||
| decreaseKnownBigLedgerPeers _ _ targets base = | |||
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
crocodile-dentist
force-pushed
the
mwojtowicz/churn-no-timeouts-fix
branch
from
1295559
to
ae74431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a pain to find.
resolves #4922
Checklist
Quality
Maintenance
ouroboros-networkproject.