Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full rework of the BlockFetch logic for bulk sync mode #4904

Draft
wants to merge 136 commits into
base: blockfetch/baseline
Choose a base branch
from
Draft

Full rework of the BlockFetch logic for bulk sync mode #4904

wants to merge 136 commits into from

Commits on Jun 12, 2024

  1. Split the BlockFetch.Decision module

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    db39d20 View commit details
    Browse the repository at this point in the history

  2. Start writing a simple BlockFetch decision logic

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c356465 View commit details
    Browse the repository at this point in the history

  3. Note on “bulk sync”

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9771ed0 View commit details
    Browse the repository at this point in the history

  4. Get longest candidate

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9b3693a View commit details
    Browse the repository at this point in the history

  5. Break down filterNotAlreadyFetched in two functions

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5e4a665 View commit details
    Browse the repository at this point in the history

  6. Break down filterNotAlreadyInFlightWithPeer in two functions

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cc12e86 View commit details
    Browse the repository at this point in the history

  7. More work on bulk sync block fetch

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    47bd5c3 View commit details
    Browse the repository at this point in the history

  8. Filter plausible and in flight with other peer

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1cd371e View commit details
    Browse the repository at this point in the history

  9. Yay movin' forward

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    18e2fed View commit details
    Browse the repository at this point in the history

  10. Choose the candidate to get and try to fetch it 

    ...except the fetch function is not implemented yet
    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    837d017 View commit details
    Browse the repository at this point in the history

  11. Getting there

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3d71e47 View commit details
    Browse the repository at this point in the history

  12. Move fetchRequestDecision to Common 

    ... but not `fetchRequestDecisions` that still belongs to the deadline
mode: the bulksync mode is only interested in deciding for one candidate.
    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    86fccf6 View commit details
    Browse the repository at this point in the history

  13. First implementation of a naive bulk sync decision logic

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    69b7c28 View commit details
    Browse the repository at this point in the history

  14. Some notes here and there

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d5b5fd2 View commit details
    Browse the repository at this point in the history

  15. Better filtering of peers if they don't provide the fragments

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    bc07066 View commit details
    Browse the repository at this point in the history

  16. A note

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5fffd66 View commit details
    Browse the repository at this point in the history

  17. Allow reading a peer queue in the consensus interface

    @Niols
    Niols committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c5c802b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Use peer order in decision

    @Niols
    Niols committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a535930 View commit details
    Browse the repository at this point in the history

  2. Keep peers order internal

    @Niols
    Niols committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e37410c View commit details
    Browse the repository at this point in the history

  3. Add action to demote the dynamo

    @Niols
    Niols committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3ac66dd View commit details
    Browse the repository at this point in the history

  4. Keep more granular decisions for each peer

    @Niols
    Niols committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9ffe465 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Documentation

    @Niols
    Niols committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    db3f862 View commit details
    Browse the repository at this point in the history

  2. Some minor improvements

    @Niols
    Niols committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    54e6cbc View commit details
    Browse the repository at this point in the history

  3. Rewrite with new logic 

    as discussed in the sync
    @Niols
    Niols committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    32bfd08 View commit details
    Browse the repository at this point in the history

  4. Simplify types

    @Niols
    Niols committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    082fe81 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Make selectTheCandidate return a WithDeclined

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    60ab44b View commit details
    Browse the repository at this point in the history

  2. Make selectThePeer return a WithDeclined

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    24ef98c View commit details
    Browse the repository at this point in the history

  3. Use actual transformers

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d56d2c5 View commit details
    Browse the repository at this point in the history

  4. Remove MaybeT from WithDeclined

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7ac4bb5 View commit details
    Browse the repository at this point in the history

  5. Inline partitionEithersFirst

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4771b82 View commit details
    Browse the repository at this point in the history

  6. Some documentation

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2953e5a View commit details
    Browse the repository at this point in the history

  7. Document selectThePeer

    @Niols
    Niols committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    238eb08 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Add the last ChainSel starvation time to consensus interface

    @Niols
    Niols committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7c63658 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Make peerFetchBlocksInFlight a map

    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    43951c4 View commit details
    Browse the repository at this point in the history

  2. Record the time at which a block was requested

    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3a284db View commit details
    Browse the repository at this point in the history

  3. Wrapper type for PeersOrder 

    ...on the way to tracking the currently-chosen peer
    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a44198a View commit details
    Browse the repository at this point in the history

  4. Revert "Record the time at which a block was requested" 

    This reverts commit 3a284db.
    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d4e295d View commit details
    Browse the repository at this point in the history

  5. The bulk sync decision function returns the actual request

    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    01faa03 View commit details
    Browse the repository at this point in the history

  6. Make fetchDecisions return a monadic action

    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    55465ac View commit details
    Browse the repository at this point in the history

  7. Update the peers order following the blockfetch decision

    @Niols
    Niols committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    33afee7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Write the peers order and record the start time

    @Niols
    Niols committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6587d1c View commit details
    Browse the repository at this point in the history

  2. Check last ChainSel starvation

    @Niols
    Niols committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1154905 View commit details
    Browse the repository at this point in the history

  3. Make grace period very small for testing purposes

    @Niols
    Niols committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3c4aae7 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Get more information from ChainSel starvation

    @Niols
    Niols committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    dfe0abd View commit details
    Browse the repository at this point in the history

  2. Export mcons and msnoc close to PeersOrder

    @Niols
    Niols committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f32d171 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. More efficient implementation of trimFragmentsToCandidate

    @Niols
    Niols committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fda748d View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Some fixes

    @Niols
    Niols committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cc689fb View commit details
    Browse the repository at this point in the history

  2. Some comments and types

    @Niols
    Niols committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d63b00a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. [TRYOUT] Get rid of some tells

    @Niols
    Niols committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    354fec9 View commit details
    Browse the repository at this point in the history

  2. Grace period of 10 seconds

    @Niols
    Niols committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b8072f View commit details
    Browse the repository at this point in the history

  3. Make grace period configurable

    @Niols
    Niols committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c8b8cc5 View commit details
    Browse the repository at this point in the history

  4. Fix handling of ongoing starvation

    @Niols
    Niols committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b3650ee View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Make fetchTheCandidate also return a Writer Maybe

    @Niols
    Niols committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0308e0c View commit details
    Browse the repository at this point in the history

  2. Switch to CPS Writer

    @Niols
    Niols committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1b717f2 View commit details
    Browse the repository at this point in the history

  3. Revert "[TRYOUT] Get rid of some tells" 

    This reverts commit 354fec9.
    @Niols
    Niols committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2ba5078 View commit details
    Browse the repository at this point in the history

  4. Avoid Writer [a]

    @Niols
    Niols committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1b8a232 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. More performant (hopefully) toList

    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e58a48f View commit details
    Browse the repository at this point in the history

  2. Mark blocks as ignored when demoting peer

    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    dd92744 View commit details
    Browse the repository at this point in the history

  3. Ignore blocks when choosing the peer to sync from

    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    37622e2 View commit details
    Browse the repository at this point in the history

  4. Fix duplication in peers order

    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    85d9cc7 View commit details
    Browse the repository at this point in the history

  5. Also ignore blocks in flight by other peers in actual request, and co… 

    …de refactoring
    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8ab4062 View commit details
    Browse the repository at this point in the history

  6. Code cleanup

    @Niols
    Niols committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e475726 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Cleanup

    @Niols
    Niols committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3b978c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Remove useless comment

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    89ffb2e View commit details
    Browse the repository at this point in the history

  2. Improve comments of filterNotAlready...

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d4a453d View commit details
    Browse the repository at this point in the history

  3. Mention that grossRequest implies refinedRequest

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0be0889 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions by @facundominguez 

    Co-authored-by: Facundo Domínguez <facundominguez@gmail.com>
    @Niols @facundominguez
    Niols and facundominguez committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d28e315 View commit details
    Browse the repository at this point in the history

  5. Check if blocks in flight before demoting

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3890175 View commit details
    Browse the repository at this point in the history

  6. Compatiblity with older GHC/packages in cardano-node

    @nbacquey
    nbacquey committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9e69d60 View commit details
    Browse the repository at this point in the history

  7. Fix PeersOrder

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8c07b58 View commit details
    Browse the repository at this point in the history

  8. Move important part of fetchDecisions into BulkSync

    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    59c11f9 View commit details
    Browse the repository at this point in the history

  9. Bring back everything to Deadline 

    ...so that the previous comments make sense
    @Niols
    Niols committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4361031 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Rename checkChangeOfCurrentPeer to maybeSetCurrentPeer

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7044561 View commit details
    Browse the repository at this point in the history

  2. Better comment for filterNotAlreadyInFlightWithPeer

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7dd8434 View commit details
    Browse the repository at this point in the history

  3. First draft documentation for BulkSync

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f43032b View commit details
    Browse the repository at this point in the history

  4. Re-record a new start time when no inflight blocks

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bc4451e View commit details
    Browse the repository at this point in the history

  5. Switch gross request to 20 mebibytes

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    40ec6bc View commit details
    Browse the repository at this point in the history

  6. Document on grossRequest's non-emptiness

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4438847 View commit details
    Browse the repository at this point in the history

  7. Remove useless FIXME

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d615b8f View commit details
    Browse the repository at this point in the history

  8. fetchDecisions (mind the s) is only used by FetchModeDeadline

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2ca7b8b View commit details
    Browse the repository at this point in the history

  9. Remove unused argument maxConcurrencyBulkSync

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9f338a4 View commit details
    Browse the repository at this point in the history

  10. Document the interaction with CSJ

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4205e68 View commit details
    Browse the repository at this point in the history

  11. Add documentation about the gross request

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    04be7c4 View commit details
    Browse the repository at this point in the history

  12. Mebibytes, not megabytes ---

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e5db153 View commit details
    Browse the repository at this point in the history

  13. Ignore all blocks in flight when demoting

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4ec0778 View commit details
    Browse the repository at this point in the history

  14. Keep using the same peer until it starves us

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d35ab47 View commit details
    Browse the repository at this point in the history

  15. Avoid having two slightly-different notions of current peers

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    90084d4 View commit details
    Browse the repository at this point in the history

  16. Last fixes

    @Niols
    Niols committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4c84463 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. A proper datatype for blockfetch decision tracing

    @Niols
    Niols committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2d2d07a View commit details
    Browse the repository at this point in the history

  2. Remove useless filterNotAlreadyInFlightWithAny...

    @Niols
    Niols committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8db3f2d View commit details
    Browse the repository at this point in the history

  3. filterNot -> drop

    @Niols
    Niols committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    270c02e View commit details
    Browse the repository at this point in the history

  4. typos

    @Niols
    Niols committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4ba0e83 View commit details
    Browse the repository at this point in the history

  5. Trace when peer starved us

    @Niols
    Niols committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    33ffeb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Extract Genesis-specific config params in their own type

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7a84d64 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Update documentation to the latest design 

    - Incorporate Nick's remark that we should just keep the current peer.
- Incorporate Facundo's remark that ignored in-flight blocks are not
  necessary anymore.
    @Niols
    Niols committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bef3798 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Make in-flight blocks a set again

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a508f06 View commit details
    Browse the repository at this point in the history

  2. Current peer only if inflight blocks

    @Niols
    Niols committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c451191 View commit details
    Browse the repository at this point in the history

  3. Put only one block in the gross request

    @facundominguez
    facundominguez committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3626625 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Add missing instances for GenesisBlockFetchCOnfiguration

    @nbacquey
    nbacquey committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ba6d7ea View commit details
    Browse the repository at this point in the history

  2. Drop the empty fragments from the final request

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    33bcad5 View commit details
    Browse the repository at this point in the history

  3. Remove extractFirstElement

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6e6eae8 View commit details
    Browse the repository at this point in the history

  4. Remove eqPeerInfo

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6a2e8d8 View commit details
    Browse the repository at this point in the history

  5. Rename fetchTheCandidate to makeFetchRequest

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    59c250b View commit details
    Browse the repository at this point in the history

  6. Groom comments

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1626277 View commit details
    Browse the repository at this point in the history

  7. Groom auxiliary definition theFragments

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2a4d66b View commit details
    Browse the repository at this point in the history

  8. Groom fetchDecisionsBulkSync

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    546adc4 View commit details
    Browse the repository at this point in the history

  9. Address review comment to optimize checks when selecting the peer

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d7c1196 View commit details
    Browse the repository at this point in the history

  10. Groom comments

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b24e05c View commit details
    Browse the repository at this point in the history

  11. Use peerInfoPeer instead of pattern matching

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fe917f3 View commit details
    Browse the repository at this point in the history

  12. Retrieve PeerInfo of the current peer where it is used

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    717d49f View commit details
    Browse the repository at this point in the history

  13. Groom makeFetchRequest

    @facundominguez
    facundominguez committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ff1d5ac View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Revert "Note on “bulk sync”" 

    This reverts commit 9771ed0.
    @facundominguez
    facundominguez committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    460d18f View commit details
    Browse the repository at this point in the history

  2. Set the default decision loop interval to 40 ms

    @facundominguez
    facundominguez committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7686f9c View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Separate the decision loop interval for bulksync and deadline modes

    @facundominguez
    facundominguez committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7284bda View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Make the output more descriptive on failures of the BlockFetch tests

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    34c829f View commit details
    Browse the repository at this point in the history

  2. Fix typo in error message

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    439116a View commit details
    Browse the repository at this point in the history

  3. Have failing BlockFetch tests terminate

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f4a335d View commit details
    Browse the repository at this point in the history

  4. Fix expectations of test 'static chains without overlap'

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ad95337 View commit details
    Browse the repository at this point in the history

  5. Fix expectations of test 'static chains with overlap'

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    178872f View commit details
    Browse the repository at this point in the history

  6. Refactoring: resolve declination of the candidate fragments early

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    38152f3 View commit details
    Browse the repository at this point in the history

  7. Sort the peers only once in the decision logic

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    43b4491 View commit details
    Browse the repository at this point in the history

  8. Don't update de peers order prematurely

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f6a9152 View commit details
    Browse the repository at this point in the history

  9. Change the current peer if it cannot provide the gross request

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    60ea108 View commit details
    Browse the repository at this point in the history

  10. Put the current peer at the front of the peers order

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    27c819d View commit details
    Browse the repository at this point in the history

  11. Relax the predicates of 'static chains with/out overlap'

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4373d13 View commit details
    Browse the repository at this point in the history

  12. Rename BlockFetch tests that only test BulkSync mode

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0675bfc View commit details
    Browse the repository at this point in the history

  13. fixup: Separate the decision loop interval for bulksync and deadline … 

    …modes
    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    427c92d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Delete extract

    @facundominguez
    facundominguez committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    576a425 View commit details
    Browse the repository at this point in the history

  2. Update the current peer every time it has changed.

    @facundominguez
    facundominguez committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    441d6d7 View commit details
    Browse the repository at this point in the history

  3. Adjust documentation after putting the current peer at the front of p… 

    …eersOrder
    @facundominguez
    facundominguez committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    69986a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Flip calls to align peers and check starvation

    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9ad28ad View commit details
    Browse the repository at this point in the history

  2. Run the BlockFetch logic at least once every grace period

    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6438401 View commit details
    Browse the repository at this point in the history

  3. Use compareCandidateChains to select a chain in BulkSync BlockFetch

    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6162644 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Replace custom type ListConcat with DList

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    45ec560 View commit details
    Browse the repository at this point in the history

  2. use Seq instead of List for peersOrderAll

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    12a0f1f View commit details
    Browse the repository at this point in the history

  3. Replace filter by assertion when building gross request

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9abfde5 View commit details
    Browse the repository at this point in the history