Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pipelining of future blocks #4334

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bartfrenk
Copy link
Contributor

@bartfrenk bartfrenk commented Feb 2, 2023

Description

Supersedes #4310.

Updates chain selection to first check for blocks from the future before setting the tentative header. This avoids pipelining blocks from the future.

  • 1bc9135 by @nfrisby.
  • Testing to ensure future blocks are not emitted to followers.

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@bartfrenk bartfrenk force-pushed the bartfrenk/private-16/no-future-blocks-pipelining branch from 1c11894 to b4107ff Compare February 2, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants