Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty withdrawals #4630

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Sep 16, 2024

Description

  • Disallow empty treasury withdrawals, closes: Disallow empty treasury withdrawals #4582
  • Add some tests concerning withdrawals from accounts delegated to expired or unregistered Dreps
  • Add CERTS spec and some tests concerning withdrawals that are checked in Certs rule

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu changed the title Add withdrawal test cases for delegations unregistered and expired DReps Disallow empty withdrawals Sep 16, 2024
@teodanciu teodanciu marked this pull request as ready for review September 18, 2024 14:24
@teodanciu teodanciu requested a review from a team as a code owner September 18, 2024 14:24
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch 4 times, most recently from 84a6157 to 78cbf4e Compare September 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow empty treasury withdrawals
1 participant