Fix committee fkey cascade behaviour

IntersectMBO · Aug 28, 2024 · c1443b8 · c1443b8
1 parent 61d22d3
commit c1443b8
Show file tree

Hide file tree

Showing 12 changed files with 32 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Revision history for cardano-db-sync
 
+## 13.5.0.0
+- Fix a crtitical bug with committee foreign key, that could cause crashes
+
 ## 13.4.1.0
 - Fix consumed_by option for Byron inputs. A migration fixes old wrong values in place. [#1821]
 - Fix only-utxo preset populating the metadata instead of the multiassets

diff --git a/cardano-chain-gen/cardano-chain-gen.cabal b/cardano-chain-gen/cardano-chain-gen.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-chain-gen
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               A fake chain generator for testing cardano DB sync.
 description:            A fake chain generator for testing cardano DB sync.
 homepage:               https://github.com/IntersectMBO/cardano-db-sync

diff --git a/cardano-db-sync/cardano-db-sync.cabal b/cardano-db-sync/cardano-db-sync.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-db-sync
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               The Cardano DB Sync node
 description:            A Cardano node that follows the Cardano chain and inserts data from the
                         chain into a PostgresQL database.

diff --git a/cardano-db-sync/src/Cardano/DbSync/Sync.hs b/cardano-db-sync/src/Cardano/DbSync/Sync.hs
@@ -214,7 +214,7 @@ dbSyncProtocols syncEnv metricsSetters tc codecConfig version bversion =
       case consumedFixed of
         Nothing -> oldActionFixes channel
         Just wrongEntriesSize | wrongEntriesSize == 0 -> do
-          logInfo tracer "Found no wrong entries"
+          logInfo tracer "Found no wrong consumed_by_tx_id entries"
           oldActionFixes channel
         Just wrongEntriesSize -> do
           logInfo tracer $

diff --git a/cardano-db-tool/cardano-db-tool.cabal b/cardano-db-tool/cardano-db-tool.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-db-tool
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               Utilities to manage the cardano-db-sync databases.
 description:            Utilities and executable, used to manage and validate the
                         PostgreSQL db and the ledger database of the cardano-db-sync node

diff --git a/cardano-db/cardano-db.cabal b/cardano-db/cardano-db.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-db
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               A base PostgreSQL component for the cardano-db-sync node.
 description:            Code for the Cardano DB Sync node that is shared between the
                         cardano-db-node and other components.

diff --git a/cardano-db/src/Cardano/Db/Schema.hs b/cardano-db/src/Cardano/Db/Schema.hs
@@ -641,7 +641,7 @@ share
     quorumDenominator    Word64
 
   CommitteeMember
-    committeeId          CommitteeId   -- here intentionally we use foreign keys
+    committeeId          CommitteeId          OnDeleteCascade -- here intentionally we use foreign keys
     committeeHashId      CommitteeHashId      noreference
     expirationEpoch      Word64               sqltype=word31type
 

diff --git a/cardano-db/test/cardano-db-test.cabal b/cardano-db/test/cardano-db-test.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-db-test
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               Tests for the base functionality of the cardano-db library
 description:            Code for the Cardano DB Sync node that is shared between the
                         cardano-db-node and other components.

diff --git a/cardano-smash-server/cardano-smash-server.cabal b/cardano-smash-server/cardano-smash-server.cabal
@@ -1,7 +1,7 @@
 cabal-version:          3.6
 
 name:                   cardano-smash-server
-version:                13.4.1.0
+version:                13.5.0.0
 synopsis:               The Cardano smash server
 description:            Please see the README on GitHub at
                         <https://github.com/IntersectMBO/cardano-db-sync/cardano-smash-server/#readme>

diff --git a/doc/schema.md b/doc/schema.md
@@ -1,7 +1,5 @@
 # Schema Documentation for cardano-db-sync
 
-**Note:** This file is auto-generated from the documentation in cardano-db/src/Cardano/Db/Schema.hs by the command `cabal run -- gen-schema-docs doc/schema.md`. This document should only be updated during the release process and updated on the release branch.
-
 ### `schema_version`
 
 The version of the database schema. Schema versioning is split into three stages as detailed below. This table should only ever have a single row.

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -54,7 +54,7 @@ services:
         max-file: "10"
 
   cardano-db-sync:
-    image: ghcr.io/intersectmbo/cardano-db-sync:13.4.0.0
+    image: ghcr.io/intersectmbo/cardano-db-sync:13.5.0.0
     environment:
       - DB_SYNC_CONFIG=${DB_SYNC_CONFIG:-}
       - DISABLE_LEDGER=${DISABLE_LEDGER}

diff --git a/schema/migration-2-0043-20240828.sql b/schema/migration-2-0043-20240828.sql
@@ -0,0 +1,20 @@
+-- Persistent generated migration.
+
+CREATE FUNCTION migrate() RETURNS void AS $$
+DECLARE
+  next_version int ;
+BEGIN
+  SELECT stage_two + 1 INTO next_version FROM schema_version ;
+  IF next_version = 43 THEN
+    EXECUTE 'ALTER TABLE "committee_member" DROP CONSTRAINT "committee_member_committee_id_fkey"' ;
+    EXECUTE 'ALTER TABLE "committee_member" ADD CONSTRAINT "committee_member_committee_id_fkey" FOREIGN KEY("committee_id") REFERENCES "committee"("id") ON DELETE CASCADE  ON UPDATE RESTRICT' ;
+    -- Hand written SQL statements can be added here.
+    UPDATE schema_version SET stage_two = next_version ;
+    RAISE NOTICE 'DB has been migrated to stage_two version %', next_version ;
+  END IF ;
+END ;
+$$ LANGUAGE plpgsql ;
+
+SELECT migrate() ;
+
+DROP FUNCTION migrate() ;