Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert gh-2082 with w/a for gemm issue in OneMKL #2101

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 11, 2024

The issue has been resolved by OneMKL team in scope of 2025.0 release. Thus the PR proposes to remove the workaround #gh-2082 from dpnp code.
While the testing is extended to cover the issue explicitly with matmul function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 11, 2024
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2101/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant