Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dpnp.reshape to use shape keyword argument instead of newshape #2080

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update dpnp.reshape to use shape keyword argument instead of newshape #2080

wants to merge 6 commits into from
+307 −85

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 1, 2024 •
edited
Loading

In this PR, dpnp.reshape and dpnp.ndarray.reshape are updated to align with changes in NumPy 2.1 and support for order="A" is added.
Accordingly, dpnp.ravel is also updated.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 1, 2024
@vtavana @antonwolfy
Update dpnp/dpnp_iface_manipulation.py
e08d8c1 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull/2080/index.html

antonwolfy
antonwolfy reviewed Oct 3, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Oct 3, 2024
View reviewed changes
tests/test_manipulation.py Show resolved Hide resolved
tests/test_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Oct 4, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy