Merge d62e6f2 into bd6562a

IntelPython · Oct 11, 2024 · ec10c6e · ec10c6e
2 parents bd6562a + d62e6f2
commit ec10c6e
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 21 deletions.
diff --git a/dpnp/backend/extensions/ufunc/elementwise_functions/gcd.cpp b/dpnp/backend/extensions/ufunc/elementwise_functions/gcd.cpp
@@ -95,16 +95,6 @@ struct OutputType
                                         T2,
                                         std::int64_t,
                                         std::int64_t>,
-        td_ns::BinaryTypeMapResultEntry<T1,
-                                        std::uint64_t,
-                                        T2,
-                                        std::int64_t,
-                                        std::uint64_t>,
-        td_ns::BinaryTypeMapResultEntry<T1,
-                                        std::int64_t,
-                                        T2,
-                                        std::uint64_t,
-                                        std::int64_t>,
         td_ns::DefaultResultEntry<void>>::result_type;
 };
 

diff --git a/dpnp/backend/extensions/ufunc/elementwise_functions/lcm.cpp b/dpnp/backend/extensions/ufunc/elementwise_functions/lcm.cpp
@@ -95,16 +95,6 @@ struct OutputType
                                         T2,
                                         std::int64_t,
                                         std::int64_t>,
-        td_ns::BinaryTypeMapResultEntry<T1,
-                                        std::uint64_t,
-                                        T2,
-                                        std::int64_t,
-                                        std::uint64_t>,
-        td_ns::BinaryTypeMapResultEntry<T1,
-                                        std::int64_t,
-                                        T2,
-                                        std::uint64_t,
-                                        std::int64_t>,
         td_ns::DefaultResultEntry<void>>::result_type;
 };
 

diff --git a/dpnp/backend/kernels/elementwise_functions/gcd.hpp b/dpnp/backend/kernels/elementwise_functions/gcd.hpp
@@ -38,6 +38,9 @@ struct GcdFunctor
 
     resT operator()(const argT1 &in1, const argT2 &in2) const
     {
+        static_assert(std::is_same_v<argT1, argT2>,
+                      "Input types are expected to be the same");
+
         return oneapi::dpl::gcd(in1, in2);
     }
 };

diff --git a/dpnp/backend/kernels/elementwise_functions/lcm.hpp b/dpnp/backend/kernels/elementwise_functions/lcm.hpp
@@ -38,7 +38,22 @@ struct LcmFunctor
 
     resT operator()(const argT1 &in1, const argT2 &in2) const
     {
-        return oneapi::dpl::lcm(in1, in2);
+        static_assert(std::is_same_v<argT1, argT2>,
+                      "Input types are expected to be the same");
+
+        if (in1 == 0 || in2 == 0)
+            return 0;
+
+        resT res = in1 / oneapi::dpl::gcd(in1, in2) * in2;
+        if constexpr (std::is_signed_v<argT1>) {
+            if (res < 0) {
+                return -res;
+            }
+        }
+        return res;
+
+        // TODO: address the issue to OneDPL team
+        // return oneapi::dpl::lcm(in1, in2);
     }
 };
 } // namespace dpnp::kernels::lcm