Implements `dpctl.tensor.count_nonzero` and `dpctl.tensor.diff` #1732

ndgrigorian · 2024-07-13T23:05:41Z

This PR proposes introducing two new functions to dpctl which will be coming to the array API specification's next version: count_nonzero and diff.

count_nonzero casts an array to bool before calling sum. As dedicated kernels for sum of bool into any integer type, the summation won't require any additional copies.
diff recursively takes the n-th forward difference along a given axis of an array. prepend and append arguments (which can be arrays or scalars) are concatenated to the input array. We diverge from the array API by permitting scalars for prepend and append as well as not constraining them to the same type as the input array

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2024-07-13T23:40:02Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

coveralls · 2024-07-13T23:46:05Z

coverage: 87.736% (+0.1%) from 87.614%
when pulling 6520cc0 on diff-count-nonzero-array-api
into c7af3a0 on master.

github-actions · 2024-07-14T19:22:19Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_106 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

github-actions · 2024-07-29T14:58:53Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_180 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

dpctl/tensor/_reduction.py

dpctl/tensor/_utility_functions.py

github-actions · 2024-07-30T17:15:18Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_192 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

github-actions · 2024-07-30T18:13:22Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

github-actions · 2024-07-30T18:42:41Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_195 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-30T20:15:02Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_196 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-30T21:06:38Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_200 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-30T23:37:21Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_207 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

github-actions · 2024-07-31T01:10:04Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_208 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-31T01:57:39Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_207 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-31T18:48:40Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_211 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

…o_weak_types` to `_type_utils`

…n n > 2 Saves some temporary memory allocations

…defined in the same file

Typos caused this to result in incorrect shaped outputs

…case

…icient Also adds a correctness check

github-actions · 2024-07-31T20:43:10Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_220 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-07-31T20:54:30Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_221 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

dpctl/tests/test_tensor_diff.py

github-actions · 2024-08-01T16:13:51Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_226 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-01T16:45:00Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_227 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

oleksandr-pavlyk · 2024-08-01T22:16:21Z

Please add tensor.diff and tensor.count_nonzero to docs.

ndgrigorian · 2024-08-01T22:19:18Z

Please add tensor.diff and tensor.count_nonzero to docs.

I will add nextafter too, since it was forgotten

github-actions · 2024-08-01T23:03:06Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_228 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

oleksandr-pavlyk · 2024-08-01T23:03:46Z

On the diff page, can the bullet be changed into an indent?

github-actions · 2024-08-02T00:00:55Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_229 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

oleksandr-pavlyk

Thank you @ndgrigorian ! Ready to be merged

ndgrigorian requested a review from oleksandr-pavlyk July 13, 2024 23:18

ndgrigorian force-pushed the diff-count-nonzero-array-api branch from 2e6725d to 3315646 Compare July 29, 2024 14:18

oleksandr-pavlyk reviewed Jul 29, 2024

View reviewed changes

dpctl/tensor/_reduction.py Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Jul 29, 2024

View reviewed changes

dpctl/tensor/_utility_functions.py Outdated Show resolved Hide resolved

ndgrigorian force-pushed the diff-count-nonzero-array-api branch from ae52dec to a5a5a72 Compare July 31, 2024 01:18

ndgrigorian marked this pull request as ready for review July 31, 2024 15:05

ndgrigorian added 11 commits July 31, 2024 13:01

Implements dpctl.tensor.diff

9ddecb0

Move _resolve_one_strong_one_weak_types and `_resolve_one_strong_tw…

442ba6f

…o_weak_types` to `_type_utils`

Implements dpctl.tensor.count_nonzero

e3432d7

Adds docstrings for diff and count_nonzero

eaaac83

Fix typo in count_nonzero caught in review

6c8a61f

diff now uses not_equal when the input is boolean

b280036

Rewrite diff to juggle between two larger temporary allocations whe…

9fb94d5

…n n > 2 Saves some temporary memory allocations

Adds a basic test for count_nonzero

234d81e

Use builtins.all in diff utilities to avoid conflicts with all …

6664b18

…defined in the same file

Adds test_tensor_diff with tests for basic diff and axis keyword

d4b575f

Fixes typo in test_count_nonzero

e5b144c

ndgrigorian added 8 commits July 31, 2024 13:01

More tests for diff

6ae2ac2

Test diff with an empty array and axis

316254b

Fixes diff for Python scalar append or prepend

fdf9ada

Typos caused this to result in incorrect shaped outputs

Corrects typo in diff

e38234a

Test diff with Python scalars for prepend and append and no-op …

c3bdf9d

…case

Corrects test_diff_no_op

dbed59a

Make diff test for appended Python scalars more thorough and more eff…

33e437a

…icient Also adds a correctness check

diff input validation tests

52a8d23

ndgrigorian force-pushed the diff-count-nonzero-array-api branch from ea67b5a to 52a8d23 Compare July 31, 2024 20:01

Refactor diff tests and improve coverage

440fb77

oleksandr-pavlyk reviewed Aug 1, 2024

View reviewed changes

dpctl/tests/test_tensor_diff.py Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Aug 1, 2024

View reviewed changes

dpctl/tests/test_tensor_diff.py Outdated Show resolved Hide resolved

Fixes per review by @oleksandr-pavlyk

16a71c3

oleksandr-pavlyk reviewed Aug 1, 2024

View reviewed changes

dpctl/tests/test_tensor_diff.py Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Aug 1, 2024

View reviewed changes

dpctl/tests/test_tensor_diff.py Outdated Show resolved Hide resolved

More PR review changes

3215c9f

Adds count_nonzero, diff, and nextafter to docs

89c1339

Change to diff docstring per PR review

6520cc0

oleksandr-pavlyk approved these changes Aug 2, 2024

View reviewed changes

ndgrigorian merged commit 1ecd8a8 into master Aug 2, 2024
40 of 41 checks passed

ndgrigorian deleted the diff-count-nonzero-array-api branch August 2, 2024 00:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements `dpctl.tensor.count_nonzero` and `dpctl.tensor.diff` #1732

Implements `dpctl.tensor.count_nonzero` and `dpctl.tensor.diff` #1732

ndgrigorian commented Jul 13, 2024

github-actions bot commented Jul 13, 2024 •

edited

Loading

coveralls commented Jul 13, 2024 •

edited

Loading

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

oleksandr-pavlyk commented Aug 1, 2024

ndgrigorian commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

oleksandr-pavlyk commented Aug 1, 2024

github-actions bot commented Aug 2, 2024

oleksandr-pavlyk left a comment

Implements dpctl.tensor.count_nonzero and dpctl.tensor.diff #1732

Implements dpctl.tensor.count_nonzero and dpctl.tensor.diff #1732

Conversation

ndgrigorian commented Jul 13, 2024

github-actions bot commented Jul 13, 2024 • edited Loading

coveralls commented Jul 13, 2024 • edited Loading

github-actions bot commented Jul 14, 2024

github-actions bot commented Jul 29, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

oleksandr-pavlyk commented Aug 1, 2024

ndgrigorian commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

oleksandr-pavlyk commented Aug 1, 2024

github-actions bot commented Aug 2, 2024

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Implements `dpctl.tensor.count_nonzero` and `dpctl.tensor.diff` #1732

Implements `dpctl.tensor.count_nonzero` and `dpctl.tensor.diff` #1732

github-actions bot commented Jul 13, 2024 •

edited

Loading

coveralls commented Jul 13, 2024 •

edited

Loading