New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata improvements #1660

Merged

oleksandr-pavlyk merged 15 commits into master from feature/pyproject

Jul 17, 2024

Collaborator

ZzEeKkAa commented May 2, 2024 •

edited

Loading

Changes in this PR:

Move all supported configuration to pyproject.toml from setup.py and setup.cfg (latest one was removed).
Populate additional fields to project and build-system sections of pyproject.toml.
Use build packages from pyproject's build-system section in the conda meta.yaml to keep it in sync.
Use package managed versioneer.

Problems:

wheel package removes symbolic links

Checklist:

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

ZzEeKkAa force-pushed the feature/pyproject branch 5 times, most recently from 020e55b to 1e7a526 Compare

May 2, 2024 22:01

Collaborator

coveralls commented May 2, 2024 •

edited

Loading

coverage: 87.892%. remained the same
when pulling 3d51b7c on feature/pyproject
into 0df3bec on master.

github-actions bot commented May 2, 2024 •

edited

Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions bot commented May 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_322 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_322 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa requested a review from oleksandr-pavlyk

May 3, 2024 14:12

ZzEeKkAa force-pushed the feature/pyproject branch from 3d51b7c to dbb731a Compare

May 3, 2024 20:42

github-actions bot commented May 3, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_323 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch 3 times, most recently from 6947845 to 54dbe67 Compare

May 4, 2024 04:42

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 54dbe67 to 6d7d79e Compare

May 4, 2024 05:02

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 6d7d79e to 1d87bae Compare

May 4, 2024 05:31

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from 1d87bae to c5fe610 Compare

May 4, 2024 05:41

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

1 similar comment

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

ZzEeKkAa force-pushed the feature/pyproject branch from c5fe610 to 57935b6 Compare

May 4, 2024 14:17

github-actions bot commented May 4, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310ha798474_334 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

oleksandr-pavlyk reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved

oleksandr-pavlyk reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

oleksandr-pavlyk mentioned this pull request

Development via pip install -e . #213

Closed

oleksandr-pavlyk reviewed

View reviewed changes

conda-recipe/build.sh Outdated Show resolved Hide resolved

github-actions bot commented Jun 7, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_76 ran successfully.
Passed: 889
Failed: 12
Skipped: 91

Collaborator

oleksandr-pavlyk commented Jun 9, 2024

Assuming my PR gh-1706 into this branch gets merged, the set of changes is a big step forward. Thank you @ZzEeKkAa for doing this work!

ZzEeKkAa added 10 commits

July 16, 2024 14:20


          Add pyproject format pre-commit

aca9a79


          Switch project meta to pyproject.toml

486637a


          Use versioneer as build dependency

6fcf0c5


          Clean up setup.py

7e411e9


          Improve error messages in cmake

96da3e8


          Use conda distibuted level-zero package

d7a676d


          Use conda distibuted pybind11 package

464a402


          Add ZzEeKkAa to conda recipe mainteiner list

8cde9c0


          Use manylinux_2_28 wheel format

6d95da4


          Update docs dependencies

679876c

ZzEeKkAa force-pushed the feature/pyproject branch from 8ebbac1 to 679876c Compare

July 16, 2024 18:20

oleksandr-pavlyk added 2 commits

July 16, 2024 13:38


          Implement manipulation of flattened SO files

2b2e160


          Skip test_syclinterface test for build with nightly sycl bundle too

3fe7608

github-actions bot commented Jul 16, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_115 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

oleksandr-pavlyk added 2 commits

July 16, 2024 15:23


          Add --no-sycl-interface-test option

7dd9f77

This option allows skipping test for copies
of symbolic links which is needed in coverage
workflow, and in workflow that builds with
nightly sycl bundle build from intel/llvm
snapshots


          Merge pull request #1706 from IntelPython/edit-to-pyproject

ebf409f

Implement manipulation of flattened SO files

github-actions bot commented Jul 17, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_119 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

Collaborator

coveralls commented Jul 17, 2024 •

edited

Loading

coverage: 87.967%. remained the same
when pulling c243318 on feature/pyproject
into 6d34a6b on master.

oleksandr-pavlyk previously approved these changes

View reviewed changes

Collaborator

oleksandr-pavlyk left a comment

Thank you @ZzEeKkAa !

ZzEeKkAa changed the title ~~Meta data improvements~~ Metadata improvements

ekomarova reviewed

View reviewed changes

conda-recipe/build.sh Show resolved Hide resolved

conda-recipe/build.sh Outdated Show resolved Hide resolved


          Strengthen check for wheel copying step

c243318

oleksandr-pavlyk dismissed their stale review via

c243318

July 17, 2024 18:06

github-actions bot commented Jul 17, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_125 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

oleksandr-pavlyk approved these changes

View reviewed changes

ekomarova approved these changes

View reviewed changes

Contributor

ekomarova left a comment

LGTM!
The problems with testing wheels are not related to this PR, and will be fixed later by infra team

oleksandr-pavlyk merged commit 71901c7 into master

41 of 46 checks passed

oleksandr-pavlyk deleted the feature/pyproject branch

July 17, 2024 22:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment