Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Return tuples instead of lists in CST nodes #631

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 27, 2022

Summary

This pr convers Vec<> to tuple during into_py, which reduces the memory usage of the CST on the Python side by about 10%.

Test Plan

CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #631 (423a52d) into main (595d8c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         245      245           
  Lines       25281    25281           
=======================================
  Hits        23963    23963           
  Misses       1318     1318           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595d8c3...423a52d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants