Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about the native parts #601

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Add docs about the native parts #601

merged 3 commits into from
Jan 15, 2022

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 13, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2022
@zsol zsol linked an issue Jan 13, 2022 that may be closed by this pull request
Developer docs need to account for the native parser #592
Closed
stroxler
stroxler approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than a formatting error (see line comment).

Thanks!

native/libcst/README.md Outdated Show resolved Hide resolved
@zsol @stroxler
Update native/libcst/README.md
3ebc626 
Co-authored-by: Steven Troxler <steven.troxler@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #601 (3ebc626) into main (5f22b6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         244      244           
  Lines       24916    24916           
=======================================
  Hits        23602    23602           
  Misses       1314     1314

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f22b6c...3ebc626. Read the comment docs.

@zsol zsol merged commit c7d76c6 into Instagram:main Jan 15, 2022
@zsol zsol deleted the docs branch January 15, 2022 12:42
This was referenced Jan 28, 2022
Merged
Merged
@renovate-bot renovate-bot mentioned this pull request Mar 2, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Mar 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stroxler stroxler stroxler approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer docs need to account for the native parser
4 participants
@zsol @codecov-commenter @stroxler @facebook-github-bot