-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyre command for type inference provider #523
Conversation
Looks like the new test is failing because |
cc @stroxler if the quotes are causing a problem, how are you not running into it? |
@zsol Updated to start and stop Pyre in test setUp and tearDown functions. |
My changes bumped the pyre version which did seem to trigger a pyre start somewhere because I had to add the The error we're getting makes me think we lack a Assuming I'm correct about this being the problem, we could fix that by manually adding one, or probably (according to https://pyre-check.org/docs/getting-started#setting-up-a-project) by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets go
Summary
Pyre command for type inference provider has one of its params quoted and causing the Pyre to fail to parse the command line.
Test Plan
Added unit test to generate the cache and compare with the expected result.