-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyre-check to latest version #516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 235 235
Lines 23097 23109 +12
=======================================
+ Hits 21880 21892 +12
Misses 1217 1217
Continue to review full report at Codecov.
|
0cd0d60
to
e852d84
Compare
Looks like we may need to launch watchman to enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep looks like watchman needs to be started beforehand, but also we might need to tweak the test itself because it expects some json
8af4c1e
to
382cccd
Compare
The current version of the pyre query api requires a running watchman server, which has to be started independently.
382cccd
to
5b30a98
Compare
Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
Summary
Bump the version of pyre to the latest, 0.0.41 is ancient.
Test Plan
and the install went okay.
I'm pretty sure this is going to lead to a huge number of errors (I get pages of them on my computer), putting the PR up partly to see what the CI results look like and partly to get feedback about how to handle it.