Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyre-check to latest version #516

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

stroxler
Copy link
Contributor

Summary

Bump the version of pyre to the latest, 0.0.41 is ancient.

Test Plan

pip install -r requirements-dev.txt

and the install went okay.

I'm pretty sure this is going to lead to a huge number of errors (I get pages of them on my computer), putting the PR up partly to see what the CI results look like and partly to get feedback about how to handle it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #516 (8af4c1e) into master (96a0b53) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         235      235           
  Lines       23097    23109   +12     
=======================================
+ Hits        21880    21892   +12     
  Misses       1217     1217           
Impacted Files Coverage Δ
...emod/visitors/tests/test_apply_type_annotations.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a0b53...8af4c1e. Read the comment docs.

@stroxler
Copy link
Contributor Author

Looks like we may need to launch watchman to enable pyre query? This is often necessary to use pyre server in CI systems, I can ask the pyre team

Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks like watchman needs to be started beforehand, but also we might need to tweak the test itself because it expects some json

@stroxler stroxler force-pushed the bump-pyre-version branch 3 times, most recently from 8af4c1e to 382cccd Compare August 31, 2021 14:04
The current version of the pyre query api requires a running
watchman server, which has to be started independently.
@stroxler
Copy link
Contributor Author

Added the --no-watchman flag to pyre start, and updated the json for some callable types that are more verbose on the current version of pyre.

Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@zsol zsol merged commit 69156c7 into Instagram:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants