Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codemodding on windows #495

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Conversation

Josverl
Copy link
Contributor

@Josverl Josverl commented Jul 2, 2021

Summary

running codemodding fails due to passing an empty environment env={} rather than env=None according to the Python spec.
Note If specified, env must provide any variables required for the program to execute. On Windows, in order to run a side-by-side assembly the specified env must include a valid SystemRoot.
by specifying env=None things work smoothly on Windows 10

fixes: #494

Test Plan

I have only performed limited testing on Windows, but this should be validated across all supported platforms.
My assumption that this is already part of the CI/CD tests

@facebook-github-bot
Copy link

Hi @Josverl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

libcst/codemod/_cli.py Outdated Show resolved Hide resolved
@zsol
Copy link
Member

zsol commented Jul 5, 2021

Thx for contributing! :)

@zsol zsol merged commit 8c19f1c into Instagram:master Jul 5, 2021
@Josverl Josverl deleted the fix_subprocess_windows branch July 5, 2021 11:56
@bgw
Copy link
Contributor

bgw commented Jul 6, 2021

After looking at the pre-OSS blame for this, it seems like the use of env={} in the first place was to work around an internal issue with an Instagram script runner. It's unclear if that issue has been resolved (though it probably has). Curious Facebook employees can look at D14541659.

@zsol
Copy link
Member

zsol commented Jul 7, 2021

Looks like that particular error has been resolved, but I see a different one today. In any case, we should fix this issue internally

@zsol zsol mentioned this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codemodding fails on windows due to error calling black with env={}
4 participants