Split QualifiedNameProvider out from libcst.metadata.scope_provider #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jimmylai
approved these changes
Mar 11, 2021
Comment on lines
1
to
2
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # |
There was a problem hiding this comment.
There is a test_qualified_name_provider.py which is duplicated with this test_name_provider.py
We should consolidate and provide a better file naming.
https://github.com/Instagram/LibCST/blob/6731aa5d2940ce82dd221963b64a496955bfd07a/libcst/metadata/tests/test_qualified_name_provider.py
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 233 234 +1
Lines 22708 22731 +23
=======================================
+ Hits 21491 21514 +23
Misses 1217 1217
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The provider is still available from
libcst.metadata. I'm planning to addFullyQualifiedNameProviderto this file too.Test Plan
New and existing tests.