Use correct type for AugAssign and AnnAssign target

[cdonovick]

Summary

Closes #391

Changes to libcst/matchers/__init__.py performed by tox -e codegen

Test Plan

I couldn't find any relevant tests to extend but would be happy to write one.

[jimmylai]

This change looks great. It makes LibCST parsing more correctly just like AST.

Can you add invalid test cases to AnnAssignTest and AugAssignTest ?
This is an example.

LibCST/libcst/_nodes/tests/test_assign.py

Lines 269 to 285 in c023fa7

	@data_provider(
	(
	{
	"get_node": (
	lambda: cst.AnnAssign(
	target=cst.Name("foo"),
	annotation=cst.Annotation(cst.Name("str")),
	equal=cst.AssignEqual(),
	value=None,
	)
	),
	"expected_re": "Must have a value when specifying an AssignEqual.",
	},
	)
	)
	def test_invalid(self, **kwargs: Any) -> None:
	self.assert_invalid(**kwargs)

[jimmylai]

Other than missing test cases, LGTM.

[cdonovick]

The suggested pattern does not quite work as *Assign._validate doesn't check types just existence/length of arguments. I tried using:

"get_node": (
   # x + 1 : int = y 
   lambda: cst.AnnAssign(...).validate_types_shallow()
)

But this generates a TypeError instead of a CSTValidationError.

I will add a new test methods (test_invalid_types / assert_invalid_types) that will call get_node().validate_types_shallow() similar to the to test_invalid / assert_invalid pattern.

[cdonovick]

Hmmm not sure what pyre is complaining about. I tried to reproduce locally but I get tons of errors on master so I must have something configured wrong.

Edit:
Possibly my intentional construction of ill-typed nodes? Is there a way to get pyre to skip something?

[zsol]

These should silence the pyre errors (since we're intentionally constructing these types incorrectly)

[jimmylai]

@cdonovick Looks good now. Thanks for contributing!