Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata] update return type of ParentNodeProvider to be CSTNode #377

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Aug 17, 2020

Summary

@Kronuz called out that the return type of ParentNodeProvider should NOT be an Optional.

That's true because the original_node set as metadata is always a CSTNode.

def on_leave(self, original_node: cst.CSTNode) -> None:
for child in original_node.children:
self.provider.set_metadata(child, original_node)
super().on_leave(original_node)

Test Plan

Existing tests.

@jimmylai jimmylai requested a review from Kronuz August 17, 2020 21:47
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2020
Copy link
Contributor

@Kronuz Kronuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmylai jimmylai merged commit dc6e7ba into Instagram:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants